drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
"fb_use_list" is used to store used or referenced frame buffers for
vp9 stateful decoder. "NULL" should be returned when getting target
frame buffer failed from "fb_use_list", not a random unexpected one.
Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
changed with v1:
- remove the added flag variable.
- update commit message.
---
drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
index 70b8383f7c8e..a27a109d8d14 100644
--- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
+++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c
@@ -226,10 +226,11 @@ static struct vdec_fb *vp9_rm_from_fb_use_list(struct vdec_vp9_inst
if (fb->base_y.va == addr) {
list_move_tail(&node->list,
&inst->available_fb_node_list);
- break;
+ return fb;
}
}
- return fb;
+
+ return NULL;
}
static void vp9_add_to_fb_free_list(struct vdec_vp9_inst *inst,
--
2.18.0
Il 03/07/23 05:59, Irui Wang ha scritto: > "fb_use_list" is used to store used or referenced frame buffers for > vp9 stateful decoder. "NULL" should be returned when getting target > frame buffer failed from "fb_use_list", not a random unexpected one. > > Signed-off-by: Irui Wang <irui.wang@mediatek.com> This commit needs a Fixes tag. Please add the relevant one and resend. Regards, Angelo > --- > changed with v1: > - remove the added flag variable. > - update commit message. > --- > drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c > index 70b8383f7c8e..a27a109d8d14 100644 > --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c > +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_if.c > @@ -226,10 +226,11 @@ static struct vdec_fb *vp9_rm_from_fb_use_list(struct vdec_vp9_inst > if (fb->base_y.va == addr) { > list_move_tail(&node->list, > &inst->available_fb_node_list); > - break; > + return fb; > } > } > - return fb; > + > + return NULL; > } > > static void vp9_add_to_fb_free_list(struct vdec_vp9_inst *inst, >
© 2016 - 2024 Red Hat, Inc.