clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static

[PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static

Posted by Tom Rix 2 years, 7 months ago

smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
  'ls1x_timer_lock' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/clocksource/timer-loongson1-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee03017..244d66835508 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
 
 #define CNTR_WIDTH		24
 
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
 
 struct ls1x_clocksource {
 	void __iomem *reg_base;
-- 
2.27.0

Re: [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static

Posted by Keguang Zhang 2 years, 7 months ago

> smatch reports
> drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
>   'ls1x_timer_lock' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Keguang Zhang <keguang.zhang@gmail.com>

> ---
>  drivers/clocksource/timer-loongson1-pwm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
> index 6335fee03017..244d66835508 100644
> --- a/drivers/clocksource/timer-loongson1-pwm.c
> +++ b/drivers/clocksource/timer-loongson1-pwm.c
> @@ -28,7 +28,7 @@
>
>  #define CNTR_WIDTH             24
>
> -DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
> +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
>
>  struct ls1x_clocksource {
>         void __iomem *reg_base;
> --
> 2.27.0
>


--
Best regards,

Keguang Zhang

[tip: timers/core] clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static

Posted by tip-bot2 for Tom Rix 2 years, 5 months ago

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Gitweb:        https://git.kernel.org/tip/bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Author:        Tom Rix <trix@redhat.com>
AuthorDate:    Sun, 02 Jul 2023 09:31:13 -04:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Fri, 18 Aug 2023 12:13:03 +02:00

clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static

smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
  'ls1x_timer_lock' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230702133113.3438049-1-trix@redhat.com
---
 drivers/clocksource/timer-loongson1-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee..244d668 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
 
 #define CNTR_WIDTH		24
 
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
 
 struct ls1x_clocksource {
 	void __iomem *reg_base;