Two cross-compilation kselftest fixes

[PATCH 2/2] selftests/proc: Do not build x86-64 tests on non-x86-64 builds

Posted by Björn Töpel 2 years, 7 months ago

From: Björn Töpel <bjorn@rivosinc.com>

The proc-empty-vm test is x86-64 only. Remove that test from
non-x86-64 builds.

Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
---
 tools/testing/selftests/proc/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/selftests/proc/Makefile
index cd95369254c0..35e765f79b6d 100644
--- a/tools/testing/selftests/proc/Makefile
+++ b/tools/testing/selftests/proc/Makefile
@@ -8,7 +8,11 @@ TEST_GEN_PROGS += fd-001-lookup
 TEST_GEN_PROGS += fd-002-posix-eq
 TEST_GEN_PROGS += fd-003-kthread
 TEST_GEN_PROGS += proc-loadavg-001
+
+ifneq (,$(filter $(ARCH),x86_64))
 TEST_GEN_PROGS += proc-empty-vm
+endif
+
 TEST_GEN_PROGS += proc-pid-vm
 TEST_GEN_PROGS += proc-self-map-files-001
 TEST_GEN_PROGS += proc-self-map-files-002
-- 
2.39.2

Re: [PATCH 2/2] selftests/proc: Do not build x86-64 tests on non-x86-64 builds

Posted by Alexey Dobriyan 2 years, 7 months ago

On Thu, Jun 29, 2023 at 06:23:00PM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc.com>
> 
> The proc-empty-vm test is x86-64 only. Remove that test from
> non-x86-64 builds.
> 
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>

What's the address space size on risc-v?

> --- a/tools/testing/selftests/proc/Makefile
> +++ b/tools/testing/selftests/proc/Makefile
> @@ -8,7 +8,11 @@ TEST_GEN_PROGS += fd-001-lookup
>  TEST_GEN_PROGS += fd-002-posix-eq
>  TEST_GEN_PROGS += fd-003-kthread
>  TEST_GEN_PROGS += proc-loadavg-001
> +
> +ifneq (,$(filter $(ARCH),x86_64))
>  TEST_GEN_PROGS += proc-empty-vm
> +endif
> +
>  TEST_GEN_PROGS += proc-pid-vm
>  TEST_GEN_PROGS += proc-self-map-files-001
>  TEST_GEN_PROGS += proc-self-map-files-002

Re: [PATCH 2/2] selftests/proc: Do not build x86-64 tests on non-x86-64 builds

Posted by Björn Töpel 2 years, 7 months ago

Alexey Dobriyan <adobriyan@gmail.com> writes:

> On Thu, Jun 29, 2023 at 06:23:00PM +0200, Björn Töpel wrote:
>> From: Björn Töpel <bjorn@rivosinc.com>
>> 
>> The proc-empty-vm test is x86-64 only. Remove that test from
>> non-x86-64 builds.
>> 
>> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
>
> What's the address space size on risc-v?

Different sizes are supported, 39b, 48b, and 57b:
Documentation/riscv/vm-layout.rst

Did you have anything particular in mind?

[PATCH 1/2] selftests/openat2: Run-time check for -fsanitize=undefined
[PATCH 2/2] selftests/proc: Do not build x86-64 tests on non-x86-64 builds