[v1] fixes and cleanups to ext4 resize

[PATCH 13/13] ext4: remove unnecessary initialization of count2 in set_flexbg_block_bitmap

Posted by Kemeng Shi 2 years, 7 months ago

We always overwrite count2 to "EXT4_CLUSTERS_PER_GROUP(sb) -
(first_cluster - start)" after its initialization in for loop
initialization statement .
Just remove unnecessary initialization of count2.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/resize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index d2b3ee50af31..327475c2e2e7 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -453,8 +453,7 @@ static int set_flexbg_block_bitmap(struct super_block *sb, handle_t *handle,
 
 	ext4_debug("mark clusters [%llu-%llu] used\n", first_cluster,
 		   last_cluster);
-	for (count2 = count; count > 0;
-	     count -= count2, first_cluster += count2) {
+	for (; count > 0; count -= count2, first_cluster += count2) {
 		ext4_fsblk_t start;
 		struct buffer_head *bh;
 		ext4_group_t group;
-- 
2.30.0

Re: [PATCH 13/13] ext4: remove unnecessary initialization of count2 in set_flexbg_block_bitmap

Posted by Theodore Ts'o 2 years, 5 months ago

On Thu, Jun 29, 2023 at 08:00:44PM +0800, Kemeng Shi wrote:
> We always overwrite count2 to "EXT4_CLUSTERS_PER_GROUP(sb) -
> (first_cluster - start)" after its initialization in for loop
> initialization statement .
> Just remove unnecessary initialization of count2.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Reviewed-by: Theodore Ts'o <tytso@mit.edu>