[PATCH 09/13] ext4: remove EXT4FS_DEBUG defination in resize.c

Kemeng Shi posted 13 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH 09/13] ext4: remove EXT4FS_DEBUG defination in resize.c
Posted by Kemeng Shi 2 years, 7 months ago
Remove EXT4FS_DEBUG defination in resize.c for following reasons:
1. EXT4FS_DEBUG will enable debug messages, it should only be defined
when debugging.
2. ext4.h included from ext4_jbd2.h after EXT4FS_DEBUG defination will
"#undef EXT4FS_DEBUG", then EXT4FS_DEBUG defination in resize.c can't
actually turn on ext4_debug messages.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/resize.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index c532bb613043..686eee65c118 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -10,8 +10,6 @@
  */
 
 
-#define EXT4FS_DEBUG
-
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/jiffies.h>
-- 
2.30.0
Re: [PATCH 09/13] ext4: remove EXT4FS_DEBUG defination in resize.c
Posted by Theodore Ts'o 2 years, 5 months ago
On Thu, Jun 29, 2023 at 08:00:40PM +0800, Kemeng Shi wrote:
> Remove EXT4FS_DEBUG defination in resize.c for following reasons:
> 1. EXT4FS_DEBUG will enable debug messages, it should only be defined
> when debugging.
> 2. ext4.h included from ext4_jbd2.h after EXT4FS_DEBUG defination will
> "#undef EXT4FS_DEBUG", then EXT4FS_DEBUG defination in resize.c can't
> actually turn on ext4_debug messages.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Reviewed-by: Theodore Ts'o <tytso@mit.edu>