[PATCH v2 4/4] blk-mq: delete unused completion_data in struct request

chengming.zhou@linux.dev posted 4 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH v2 4/4] blk-mq: delete unused completion_data in struct request
Posted by chengming.zhou@linux.dev 2 years, 7 months ago
From: Chengming Zhou <zhouchengming@bytedance.com>

After global search, I found "completion_data" in struct request
is not used anywhere, so just clean it up by the way.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 include/linux/blk-mq.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 96644d6f8d18..ab790eba5fcf 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -158,13 +158,11 @@ struct request {
 
 	/*
 	 * The rb_node is only used inside the io scheduler, requests
-	 * are pruned when moved to the dispatch queue. So let the
-	 * completion_data share space with the rb_node.
+	 * are pruned when moved to the dispatch queue.
 	 */
 	union {
 		struct rb_node rb_node;	/* sort/lookup */
 		struct bio_vec special_vec;
-		void *completion_data;
 	};
 
 	/*
-- 
2.39.2
Re: [PATCH v2 4/4] blk-mq: delete unused completion_data in struct request
Posted by Christoph Hellwig 2 years, 7 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Although I'd order it first or even send it separately as it doesn't need
any of the other changes.
Re: [PATCH v2 4/4] blk-mq: delete unused completion_data in struct request
Posted by Chengming Zhou 2 years, 7 months ago
On 2023/7/6 21:08, Christoph Hellwig wrote:
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Although I'd order it first or even send it separately as it doesn't need
> any of the other changes.

Ok, will order it first in the next version.

I thought it's too minor to send a separate patch, so put it in this series.

Thanks.