When switching from dwarf_decl_file() to die_get_decl_file(), a regression
was introduced when having a binary where the DWARF info is split to
multiple CUs. It is not possible to add probes to certain functions.

These patches introduce a testcase which shows the current regression
and a fix for the issue

Signed-off-by: Georg Müller <georgmueller@gmx.net>
Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/

---
Changes in v2:
 - Add testcase

Changes in v3:
 - start new thread
 - add stable to cc

Georg Müller (2):
  perf probe: add test for regression introduced by switch to
    die_get_decl_file
  perf probe: read DWARF files from the correct CU

 .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
 tools/perf/util/dwarf-aux.c                   |  4 +-
 2 files changed, 80 insertions(+), 1 deletion(-)
 create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh

--
2.41.0

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Masami, Arnaldo, what's up here? Georg (who is not a regular
contributor) afaics found a regression in a commit you
authored/committed and even provided a patch-set to fix it (the first
one nearly four weeks ago, e.g. before the merge window started), but
hasn't received much support from your side to get this in. Could you
please look into this to get this cleared up? Or am I missing something
and progress to fix this has been made?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


On 28.06.23 10:45, Georg Müller wrote:
> When switching from dwarf_decl_file() to die_get_decl_file(), a regression
> was introduced when having a binary where the DWARF info is split to
> multiple CUs. It is not possible to add probes to certain functions.
> 
> These patches introduce a testcase which shows the current regression
> and a fix for the issue
> 
> Signed-off-by: Georg Müller <georgmueller@gmx.net>
> Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/
> 
> ---
> Changes in v2:
>  - Add testcase
> 
> Changes in v3:
>  - start new thread
>  - add stable to cc
> 
> Georg Müller (2):
>   perf probe: add test for regression introduced by switch to
>     die_get_decl_file
>   perf probe: read DWARF files from the correct CU
> 
>  .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
>  tools/perf/util/dwarf-aux.c                   |  4 +-
>  2 files changed, 80 insertions(+), 1 deletion(-)
>  create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
> 
> --
> 2.41.0
> 
> 
> 

Em Mon, Jul 10, 2023 at 02:32:28PM +0200, Linux regression tracking (Thorsten Leemhuis) escreveu:
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
> 
> Masami, Arnaldo, what's up here? Georg (who is not a regular
> contributor) afaics found a regression in a commit you
> authored/committed and even provided a patch-set to fix it (the first
> one nearly four weeks ago, e.g. before the merge window started), but
> hasn't received much support from your side to get this in. Could you
> please look into this to get this cleared up? Or am I missing something
> and progress to fix this has been made?

I'm back from a 2 week vacation, going thru the pile, probably fell thru
the cracks and Namyung, that processed patches while I was away didn't
notice it either.

I'm checking,

- Arnaldo
 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> 
> On 28.06.23 10:45, Georg Müller wrote:
> > When switching from dwarf_decl_file() to die_get_decl_file(), a regression
> > was introduced when having a binary where the DWARF info is split to
> > multiple CUs. It is not possible to add probes to certain functions.
> > 
> > These patches introduce a testcase which shows the current regression
> > and a fix for the issue
> > 
> > Signed-off-by: Georg Müller <georgmueller@gmx.net>
> > Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/
> > 
> > ---
> > Changes in v2:
> >  - Add testcase
> > 
> > Changes in v3:
> >  - start new thread
> >  - add stable to cc
> > 
> > Georg Müller (2):
> >   perf probe: add test for regression introduced by switch to
> >     die_get_decl_file
> >   perf probe: read DWARF files from the correct CU
> > 
> >  .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
> >  tools/perf/util/dwarf-aux.c                   |  4 +-
> >  2 files changed, 80 insertions(+), 1 deletion(-)
> >  create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
> > 
> > --
> > 2.41.0
> > 
> > 
> > 

-- 

- Arnaldo

On 10.07.23 15:44, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jul 10, 2023 at 02:32:28PM +0200, Linux regression tracking (Thorsten Leemhuis) escreveu:
>> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
>> for once, to make this easily accessible to everyone.
>>
>> Masami, Arnaldo, what's up here? Georg (who is not a regular
>> contributor) afaics found a regression in a commit you
>> authored/committed and even provided a patch-set to fix it (the first
>> one nearly four weeks ago, e.g. before the merge window started), but
>> hasn't received much support from your side to get this in. Could you
>> please look into this to get this cleared up? Or am I missing something
>> and progress to fix this has been made?
> 
> I'm back from a 2 week vacation,

Welcome back and hope you found some rest.

> going thru the pile, probably fell thru
> the cracks and Namyung, that processed patches while I was away didn't
> notice it either.
> 
> I'm checking,

Great, many thx! Ciao, Thorsten

>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> --
>> Everything you wanna know about Linux kernel regression tracking:
>> https://linux-regtracking.leemhuis.info/about/#tldr
>> If I did something stupid, please tell me, as explained on that page.
>>
>>
>> On 28.06.23 10:45, Georg Müller wrote:
>>> When switching from dwarf_decl_file() to die_get_decl_file(), a regression
>>> was introduced when having a binary where the DWARF info is split to
>>> multiple CUs. It is not possible to add probes to certain functions.
>>>
>>> These patches introduce a testcase which shows the current regression
>>> and a fix for the issue
>>>
>>> Signed-off-by: Georg Müller <georgmueller@gmx.net>
>>> Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/
>>>
>>> ---
>>> Changes in v2:
>>>  - Add testcase
>>>
>>> Changes in v3:
>>>  - start new thread
>>>  - add stable to cc
>>>
>>> Georg Müller (2):
>>>   perf probe: add test for regression introduced by switch to
>>>     die_get_decl_file
>>>   perf probe: read DWARF files from the correct CU
>>>
>>>  .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
>>>  tools/perf/util/dwarf-aux.c                   |  4 +-
>>>  2 files changed, 80 insertions(+), 1 deletion(-)
>>>  create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
>>>
>>> --
>>> 2.41.0
>>>
>>>
>>>
>