[PATCH v2 0/2] perf probe: fix regression introduced by switch to die_get_decl_file

Georg Müller posted 2 patches 2 years, 7 months ago
There is a newer version of this series
.../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
tools/perf/util/dwarf-aux.c                   |  4 +-
2 files changed, 80 insertions(+), 1 deletion(-)
create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
[PATCH v2 0/2] perf probe: fix regression introduced by switch to die_get_decl_file
Posted by Georg Müller 2 years, 7 months ago
When switching from dwarf_decl_file() to die_get_decl_file(), a regression
was introduced when having a binary where the DWARF info is split to
multiple CUs. It is not possible to add probes to certain functions.

These patches introduce a testcase which shows the current regression
and a fix for the issue

Signed-off-by: Georg Müller <georgmueller@gmx.net>
Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/

---
Changes in v2:
 - Add testcase

Georg Müller (2):
  perf probe: add test for regression introduced by switch to
    die_get_decl_file
  perf probe: read DWARF files from the correct CU

 .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
 tools/perf/util/dwarf-aux.c                   |  4 +-
 2 files changed, 80 insertions(+), 1 deletion(-)
 create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh

--
2.41.0
Re: [PATCH v2 0/2] perf probe: fix regression introduced by switch to die_get_decl_file
Posted by Linux regression tracking (Thorsten Leemhuis) 2 years, 7 months ago
On 28.06.23 10:23, Georg Müller wrote:
> When switching from dwarf_decl_file() to die_get_decl_file(), a regression
> was introduced when having a binary where the DWARF info is split to
> multiple CUs. It is not possible to add probes to certain functions.
> 
> These patches introduce a testcase which shows the current regression
> and a fix for the issue
> 
> Signed-off-by: Georg Müller <georgmueller@gmx.net>
> Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/

FWIW, you in both commits might want to add a

 Cc: stable@vger.kernel.org

to ensure the fix is backported to appropriate releases (e.g. 6.4 and
6.3, if the latter doesn't go EOL earlier).

Ciao, Thorsten

P.S.: Some (I guess: most) maintainers prefer if patch series are
startet as new threads