md: clean up and fix for mddev_suspend()

[PATCH -next 0/2] md: clean up and fix for mddev_suspend()

Posted by Yu Kuai 2 years, 7 months ago

From: Yu Kuai <yukuai3@huawei.com>

This patchset is minor changes that I found by code review while I'm
working on synchronize io and array configuration. I'm planing to
refactor mddev_suspend() from:

mddev_lock
// array configuration
mddev_unlock

and:

mddev_lock
mddev_suspend
// array configuration
mddev_resume
mddev_unlock

to:

mddev_suspend
mddev_lock
// array configuration
mddev_unlock
mddev_resume

Yu Kuai (2):
  md: don't quiesce in mddev_suspend()
  md: restore 'noio_flag' for the last mddev_resume()

 drivers/md/md.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.39.2

Re: [PATCH -next 0/2] md: clean up and fix for mddev_suspend()

Posted by Yu Kuai 2 years, 7 months ago

Hi,

在 2023/06/28 9:29, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> This patchset is minor changes that I found by code review while I'm
> working on synchronize io and array configuration. I'm planing to
> refactor mddev_suspend() from:
> 
> mddev_lock
> // array configuration
> mddev_unlock
> 
> and:
> 
> mddev_lock
> mddev_suspend
> // array configuration
> mddev_resume
> mddev_unlock
> 
> to:
> 
> mddev_suspend
> mddev_lock
> // array configuration
> mddev_unlock
> mddev_resume
> 

Friendly ping ...

Thanks,
Kuai

> Yu Kuai (2):
>    md: don't quiesce in mddev_suspend()
>    md: restore 'noio_flag' for the last mddev_resume()
> 
>   drivers/md/md.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>

Re: [PATCH -next 0/2] md: clean up and fix for mddev_suspend()

Posted by Song Liu 2 years, 7 months ago

On Fri, Jul 7, 2023 at 9:25 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> Hi,
>
> 在 2023/06/28 9:29, Yu Kuai 写道:
> > From: Yu Kuai <yukuai3@huawei.com>
> >
> > This patchset is minor changes that I found by code review while I'm
> > working on synchronize io and array configuration. I'm planing to
> > refactor mddev_suspend() from:
> >
> > mddev_lock
> > // array configuration
> > mddev_unlock
> >
> > and:
> >
> > mddev_lock
> > mddev_suspend
> > // array configuration
> > mddev_resume
> > mddev_unlock
> >
> > to:
> >
> > mddev_suspend
> > mddev_lock
> > // array configuration
> > mddev_unlock
> > mddev_resume
> >
>
> Friendly ping ...

Applied to md-next. Thanks!

Song