SKU: Set to turn off EAPD control for Internal SPK.

[PATCH] SKU: Set to turn off EAPD control for Internal SPK.

Posted by dengxiang 2 years, 7 months ago

Due to unknown reason that could not support DSP function on Raptor Lake
platform using v2.5 sof-bin firmware and snd_hda_intel would disable codec
wakeup twice during snd_hda_intel initialization, Internal SPK is forbidden
to put sound outside with snd_hda_intel driver on Unis B760 sku machine.
Now find out that PIN47 EAPD status is always low for ALC897 chip on
Unis B760 sku.
Solution: set to turn off EAPD control again in avoid to mute internal SPK.

Signed-off-by: dengxiang <dengxiang@nfschina.com>
---
 sound/pci/hda/patch_realtek.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 36c4adfb11e7..bb0ee265eb7f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -534,6 +534,16 @@ static void set_eapd(struct hda_codec *codec, hda_nid_t nid, int on)
 {
 	if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
 		return;
+
+	switch (codec->core.vendor_id) {
+	case 0x10ec0897:
+	case 0x80867a50:
+		on = 0;
+		break;
+	default:
+		break;
+	}
+
 	if (snd_hda_query_pin_caps(codec, nid) & AC_PINCAP_EAPD)
 		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_EAPD_BTLENABLE,
 				    on ? 2 : 0);
-- 
2.30.2

Re: [PATCH] SKU: Set to turn off EAPD control for Internal SPK.

Posted by Takashi Iwai 2 years, 7 months ago

On Tue, 27 Jun 2023 07:58:36 +0200,
dengxiang wrote:
> 
> Due to unknown reason that could not support DSP function on Raptor Lake
> platform using v2.5 sof-bin firmware and snd_hda_intel would disable codec
> wakeup twice during snd_hda_intel initialization, Internal SPK is forbidden
> to put sound outside with snd_hda_intel driver on Unis B760 sku machine.
> Now find out that PIN47 EAPD status is always low for ALC897 chip on
> Unis B760 sku.
> Solution: set to turn off EAPD control again in avoid to mute internal SPK.
> 
> Signed-off-by: dengxiang <dengxiang@nfschina.com>
> ---
>  sound/pci/hda/patch_realtek.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 36c4adfb11e7..bb0ee265eb7f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -534,6 +534,16 @@ static void set_eapd(struct hda_codec *codec, hda_nid_t nid, int on)
>  {
>  	if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
>  		return;
> +
> +	switch (codec->core.vendor_id) {
> +	case 0x10ec0897:
> +	case 0x80867a50:
> +		on = 0;
> +		break;
> +	default:
> +		break;
> +	}

Sorry, this is definitely no-go.  It matches generically to all
devices that have this codec chip, so you'll break all those devices.


Takashi