Baisc devicetree support for Amlogic T7

[PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Xianwei Zhao 2 years, 7 months ago

Document the new T7 SoC/board device tree bindings.

T7 is an advanced application processor designed for smart display.
It integrates a powerful CPU/GPU subsystem, a secured 8K video
CODEC engine with all major peripherals.

The main system CPU is based on Big.LITTLE architecture,
with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 08d59842655c..79a8b44ffd03 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -218,6 +218,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic T7 A311D2 SoC
+        items:
+          - enum:
+              - amlogic,an400
+          - const: amlogic,t7
+
 additionalProperties: true
 
 ...
-- 
2.37.1

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Christian Hewitt 2 years, 7 months ago

> On 26 Jun 2023, at 1:52 pm, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
> 
> Document the new T7 SoC/board device tree bindings.
> 
> T7 is an advanced application processor designed for smart display.
> It integrates a powerful CPU/GPU subsystem, a secured 8K video
> CODEC engine with all major peripherals.

^ please avoid marketing text in commit messages (and same for the
other commits in this series).

> The main system CPU is based on Big.LITTLE architecture,
> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.

“T7 is an Amlogic SoC for smart display applications. The main CPU is
based on a big.LITTLE architecture with a quad-core A73 cluster and
quad-core A53 cluster.”

Christian

> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 08d59842655c..79a8b44ffd03 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -218,6 +218,12 @@ properties:
>               - amlogic,aq222
>           - const: amlogic,s4
> 
> +      - description: Boards with the Amlogic T7 A311D2 SoC
> +        items:
> +          - enum:
> +              - amlogic,an400
> +          - const: amlogic,t7
> +
> additionalProperties: true
> 
> ...
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Xianwei Zhao 2 years, 7 months ago

Hi Christian,
       Thanks for your advice.

On 2023/6/27 16:56, Christian Hewitt wrote:
> [你通常不会收到来自 christianshewitt@gmail.com 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
> 
> [ EXTERNAL EMAIL ]
> 
>> On 26 Jun 2023, at 1:52 pm, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>>
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
> 
> ^ please avoid marketing text in commit messages (and same for the
> other commits in this series).
> 
Will do
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
> 
> “T7 is an Amlogic SoC for smart display applications. The main CPU is
> based on a big.LITTLE architecture with a quad-core A73 cluster and
> quad-core A53 cluster.”
> 
Will do
> Christian
> 
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 08d59842655c..79a8b44ffd03 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -218,6 +218,12 @@ properties:
>>                - amlogic,aq222
>>            - const: amlogic,s4
>>
>> +      - description: Boards with the Amlogic T7 A311D2 SoC
>> +        items:
>> +          - enum:
>> +              - amlogic,an400
>> +          - const: amlogic,t7
>> +
>> additionalProperties: true
>>
>> ...
>> --
>> 2.37.1
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 26/06/2023 11:52, Xianwei Zhao wrote:
> Document the new T7 SoC/board device tree bindings.
> 
> T7 is an advanced application processor designed for smart display.
> It integrates a powerful CPU/GPU subsystem, a secured 8K video
> CODEC engine with all major peripherals.
> 
> The main system CPU is based on Big.LITTLE architecture,
> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
> 


If there is going to be new version, subject: drop second/last,
redundant "bindings". The "dt-bindings" prefix is already stating that
these are bindings.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Xianwei Zhao 2 years, 7 months ago

Hi Krzysztof,
       Thank you for your reply.

On 2023/6/26 23:38, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
>>
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
>>
>
> If there is going to be new version, subject: drop second/last,
> redundant "bindings". The "dt-bindings" prefix is already stating that
> these are bindings.
Will drop "bindings" in next version, thanks.
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

Posted by Xianwei Zhao 2 years, 7 months ago

Hi Krzysztof,
       Thank you for your reply.

On 2023/6/26 23:38, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
>>
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
>>
>
> If there is going to be new version, subject: drop second/last,
> redundant "bindings". The "dt-bindings" prefix is already stating that
> these are bindings.
will drop bindings in next version, thanks.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>