[v2] correct the lpuart compatible for imx8dxl and imx93

[PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string

Posted by Sherry Sun 2 years, 7 months ago

Add imx8ulp compatible string in lpuart dt-binding, also correct the
imx93 compatible here, imx93/imx8ulp add some new features based on
imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to enable
those new features.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index 93062403276b..272bfbb1cdfc 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -21,12 +21,15 @@ properties:
           - fsl,ls1021a-lpuart
           - fsl,ls1028a-lpuart
           - fsl,imx7ulp-lpuart
+          - fsl,imx8ulp-lpuart
           - fsl,imx8qxp-lpuart
           - fsl,imxrt1050-lpuart
       - items:
-          - enum:
-              - fsl,imx93-lpuart
-              - fsl,imx8ulp-lpuart
+          - const: fsl,imx8ulp-lpuart
+          - const: fsl,imx7ulp-lpuart
+      - items:
+          - const: fsl,imx93-lpuart
+          - const: fsl,imx8ulp-lpuart
           - const: fsl,imx7ulp-lpuart
       - items:
           - enum:
-- 
2.17.1

Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 26/06/2023 06:48, Sherry Sun wrote:
> Add imx8ulp compatible string in lpuart dt-binding, also correct the
> imx93 compatible here, imx93/imx8ulp add some new features based on
> imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to enable
> those new features.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index 93062403276b..272bfbb1cdfc 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -21,12 +21,15 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8ulp-lpuart

I don't understand this. Commit msg also does not explain this.

>            - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx93-lpuart
> -              - fsl,imx8ulp-lpuart

This could have stayed as enum with one entry which would make your diff
more readable.

> +          - const: fsl,imx8ulp-lpuart
> +          - const: fsl,imx7ulp-lpuart


Best regards,
Krzysztof

RE: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string

Posted by Sherry Sun 2 years, 7 months ago


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 2023年6月26日 23:47
> To: Sherry Sun <sherry.sun@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> Shenwei Wang <shenwei.wang@nxp.com>; gregkh@linuxfoundation.org
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> kernel@pengutronix.de; linux-serial@vger.kernel.org; linux-
> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp
> compatible string
> 
> On 26/06/2023 06:48, Sherry Sun wrote:
> > Add imx8ulp compatible string in lpuart dt-binding, also correct the
> > imx93 compatible here, imx93/imx8ulp add some new features based on
> > imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to
> > enable those new features.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9
> > ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 93062403276b..272bfbb1cdfc 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -21,12 +21,15 @@ properties:
> >            - fsl,ls1021a-lpuart
> >            - fsl,ls1028a-lpuart
> >            - fsl,imx7ulp-lpuart
> > +          - fsl,imx8ulp-lpuart
> 
> I don't understand this. Commit msg also does not explain this.

Hi Krzysztof,
Thanks for the catch, seems this is not needed as we have the below 8ulp+7ulp entry for this, will remove it in V3.

> 
> >            - fsl,imx8qxp-lpuart
> >            - fsl,imxrt1050-lpuart
> >        - items:
> > -          - enum:
> > -              - fsl,imx93-lpuart
> > -              - fsl,imx8ulp-lpuart
> 
> This could have stayed as enum with one entry which would make your diff
> more readable.
> 
> > +          - const: fsl,imx8ulp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
Sure, will change it to enum, thanks.

Best Regards
Sherry