Add document for mt7986 board with wm8960.
Signed-off-by: Maso Huang <maso.huang@mediatek.com>
---
.../sound/mediatek,mt7986-wm8960.yaml | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml
new file mode 100644
index 000000000000..76394f7e5502
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT7986 sound card with WM8960 codec
+
+maintainers:
+ - Maso Huang <maso.huang@mediatek.com>
+
+properties:
+ compatible:
+ const: mediatek,mt7986-wm8960-machine
+
+ mediatek,platform:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: The phandle of MT7986 platform.
+
+ audio-routing:
+ $ref: /schemas/types.yaml#/definitions/non-unique-string-array
+ description:
+ A list of the connections between audio components. Each entry is a
+ sink/source pair of strings. Valid names could be the input or output
+ widgets of audio components, power supplies, MicBias of codec and the
+ software switch.
+
+ mediatek,audio-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: The phandle of wm8960 codec.
+
+additionalProperties: false
+
+required:
+ - compatible
+ - mediatek,platform
+ - audio-routing
+ - mediatek,audio-codec
+
+examples:
+ - |
+ sound {
+ compatible = "mediatek,mt7986-wm8960-machine";
+ mediatek,platform = <&afe>;
+ audio-routing =
+ "Headphone", "HP_L",
+ "Headphone", "HP_R",
+ "LINPUT1", "AMIC",
+ "RINPUT1", "AMIC";
+ mediatek,audio-codec = <&wm8960>;
+ };
+
+...
--
2.18.0On Mon, Jun 26, 2023 at 10:35:00AM +0800, Maso Huang wrote: > Add document for mt7986 board with wm8960. > > Signed-off-by: Maso Huang <maso.huang@mediatek.com> > --- > .../sound/mediatek,mt7986-wm8960.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > new file mode 100644 > index 000000000000..76394f7e5502 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT7986 sound card with WM8960 codec > + > +maintainers: > + - Maso Huang <maso.huang@mediatek.com> > + > +properties: > + compatible: > + const: mediatek,mt7986-wm8960-machine > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT7986 platform. > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + sink/source pair of strings. Valid names could be the input or output > + widgets of audio components, power supplies, MicBias of codec and the > + software switch. > + > + mediatek,audio-codec: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of wm8960 codec. Please define these properties in a common schema and reference them where already used and here. A given property shouldn't have multiple type definitions. Rob
On Thu, 2023-06-29 at 08:58 -0600, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Mon, Jun 26, 2023 at 10:35:00AM +0800, Maso Huang wrote: > > Add document for mt7986 board with wm8960. > > > > Signed-off-by: Maso Huang <maso.huang@mediatek.com> > > --- > > .../sound/mediatek,mt7986-wm8960.yaml | 53 > +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > > > > diff --git > a/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml > > new file mode 100644 > > index 000000000000..76394f7e5502 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986- > wm8960.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek MT7986 sound card with WM8960 codec > > + > > +maintainers: > > + - Maso Huang <maso.huang@mediatek.com> > > + > > +properties: > > + compatible: > > + const: mediatek,mt7986-wm8960-machine > > + > > + mediatek,platform: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT7986 platform. > > + > > + audio-routing: > > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > > + description: > > + A list of the connections between audio components. Each > entry is a > > + sink/source pair of strings. Valid names could be the input > or output > > + widgets of audio components, power supplies, MicBias of > codec and the > > + software switch. > > + > > + mediatek,audio-codec: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of wm8960 codec. > > Please define these properties in a common schema and reference them > where already used and here. A given property shouldn't have > multiple > type definitions. > > Rob Hi Rob, Thanks for your review. Did you mean I need to create mediatek common part yaml and reference to it for these three properties? Or is there any example for reference for this case? Best regards, Maso
© 2016 - 2024 Red Hat, Inc.