[PATCH v6 09/13] iio: inkern: Replace a FIXME comment by a TODO one

Herve Codina posted 13 patches 2 years, 5 months ago
[PATCH v6 09/13] iio: inkern: Replace a FIXME comment by a TODO one
Posted by Herve Codina 2 years, 5 months ago
This FIXME comment is more a TODO one.
It is a note when someone will need for this currently unsupported case.

Change from FIXME to TODO.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/inkern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 8bfd91f74101..19ddd77adb11 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -879,7 +879,7 @@ static int iio_channel_read_max(struct iio_channel *chan,
 			*val = max_array(vals, length);
 			break;
 		default:
-			/* FIXME: learn about max for other iio values */
+			/* TODO: learn about max for other iio values */
 			return -EINVAL;
 		}
 		return 0;
-- 
2.40.1
Re: [PATCH v6 09/13] iio: inkern: Replace a FIXME comment by a TODO one
Posted by Christophe Leroy 2 years, 5 months ago

Le 23/06/2023 à 10:58, Herve Codina a écrit :
> This FIXME comment is more a TODO one.
> It is a note when someone will need for this currently unsupported case.
> 
> Change from FIXME to TODO.
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   drivers/iio/inkern.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 8bfd91f74101..19ddd77adb11 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -879,7 +879,7 @@ static int iio_channel_read_max(struct iio_channel *chan,
>   			*val = max_array(vals, length);
>   			break;
>   		default:
> -			/* FIXME: learn about max for other iio values */
> +			/* TODO: learn about max for other iio values */
>   			return -EINVAL;
>   		}
>   		return 0;