Remove symbol_name_rb_node

[PATCH v3 0/3] Remove symbol_name_rb_node

Posted by Ian Rogers 2 years, 7 months ago

Use a sorted array of symbol pointers to avoid the potentially
unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
been 24 and 16 bytes per symbol.

v3. Move sort by name dso lock into its own patch.
v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
    doesn't need an optional parameter. Separate out
    symbol_conf.sort_by_name removal.

Ian Rogers (3):
  perf dso: Sort symbols under lock
  perf symbol: Remove symbol_name_rb_node
  perf symbol_conf: Remove now unused sort_by_name

 tools/perf/builtin-kallsyms.c    |   1 -
 tools/perf/builtin-lock.c        |   2 -
 tools/perf/builtin-report.c      |   1 -
 tools/perf/tests/builtin-test.c  |   1 -
 tools/perf/util/dso.c            |   7 +-
 tools/perf/util/dso.h            |   3 +-
 tools/perf/util/map.c            |  14 +++-
 tools/perf/util/map.h            |  12 +--
 tools/perf/util/probe-event.c    |  16 ++--
 tools/perf/util/symbol.c         | 131 ++++++++++++++++---------------
 tools/perf/util/symbol.h         |  12 +--
 tools/perf/util/symbol_conf.h    |   1 -
 tools/perf/util/symbol_fprintf.c |  10 +--
 13 files changed, 106 insertions(+), 105 deletions(-)

-- 
2.41.0.162.gfafddb0af9-goog

Re: [PATCH v3 0/3] Remove symbol_name_rb_node

Posted by Namhyung Kim 2 years, 7 months ago

On Thu, Jun 22, 2023 at 10:45 PM Ian Rogers <irogers@google.com> wrote:
>
> Use a sorted array of symbol pointers to avoid the potentially
> unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
> been 24 and 16 bytes per symbol.
>
> v3. Move sort by name dso lock into its own patch.
> v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
>     doesn't need an optional parameter. Separate out
>     symbol_conf.sort_by_name removal.
>
> Ian Rogers (3):
>   perf dso: Sort symbols under lock
>   perf symbol: Remove symbol_name_rb_node
>   perf symbol_conf: Remove now unused sort_by_name

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
>  tools/perf/builtin-kallsyms.c    |   1 -
>  tools/perf/builtin-lock.c        |   2 -
>  tools/perf/builtin-report.c      |   1 -
>  tools/perf/tests/builtin-test.c  |   1 -
>  tools/perf/util/dso.c            |   7 +-
>  tools/perf/util/dso.h            |   3 +-
>  tools/perf/util/map.c            |  14 +++-
>  tools/perf/util/map.h            |  12 +--
>  tools/perf/util/probe-event.c    |  16 ++--
>  tools/perf/util/symbol.c         | 131 ++++++++++++++++---------------
>  tools/perf/util/symbol.h         |  12 +--
>  tools/perf/util/symbol_conf.h    |   1 -
>  tools/perf/util/symbol_fprintf.c |  10 +--
>  13 files changed, 106 insertions(+), 105 deletions(-)
>
> --
> 2.41.0.162.gfafddb0af9-goog
>

Re: [PATCH v3 0/3] Remove symbol_name_rb_node

Posted by Namhyung Kim 2 years, 7 months ago

On Fri, Jun 23, 2023 at 9:42 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Thu, Jun 22, 2023 at 10:45 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Use a sorted array of symbol pointers to avoid the potentially
> > unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
> > been 24 and 16 bytes per symbol.
> >
> > v3. Move sort by name dso lock into its own patch.
> > v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
> >     doesn't need an optional parameter. Separate out
> >     symbol_conf.sort_by_name removal.
> >
> > Ian Rogers (3):
> >   perf dso: Sort symbols under lock
> >   perf symbol: Remove symbol_name_rb_node
> >   perf symbol_conf: Remove now unused sort_by_name
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Applied to perf-tools-next, thanks!