Add a property to configure QUPv3 SE as SPI Device mode.

Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
---
v2 -> v3:
- modified commit message to use device mode instead of slave mode
---
 Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
index 2e20ca313ec1..5c7d0293bbf7 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
@@ -66,6 +66,10 @@ properties:
   reg:
     maxItems: 1
 
+  qcom,slv-ctrl:
+    description: configure QUPv3 SE as Device mode
+    type: boolean
+
 required:
   - compatible
   - clocks
-- 
2.17.1

On 22/06/2023 15:59, Praveen Talari wrote:
> Add a property to configure QUPv3 SE as SPI Device mode.
> 
> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
> ---
> v2 -> v3:
> - modified commit message to use device mode instead of slave mode
> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index 2e20ca313ec1..5c7d0293bbf7 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -66,6 +66,10 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  qcom,slv-ctrl:
> +    description: configure QUPv3 SE as Device mode

There is already property for this. Look at spi-controller.yaml. If it
is not enough, explain WHY.

Best regards,
Krzysztof

On Thu, Jun 22, 2023 at 07:29:54PM +0530, Praveen Talari wrote:
> Add a property to configure QUPv3 SE as SPI Device mode.
> 
> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
> ---
> v2 -> v3:
> - modified commit message to use device mode instead of slave mode

Suitability or w/e of the property aside, I don't understand this.
Why not change the *property*, which has far more visibility than the
commit message, to use device rather than slave?

Chers,
Conor.

> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index 2e20ca313ec1..5c7d0293bbf7 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -66,6 +66,10 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  qcom,slv-ctrl:
> +    description: configure QUPv3 SE as Device mode
> +    type: boolean
> +
>  required:
>    - compatible
>    - clocks
> -- 
> 2.17.1
> 

Hi

On 6/23/2023 12:35 AM, Conor Dooley wrote:
> On Thu, Jun 22, 2023 at 07:29:54PM +0530, Praveen Talari wrote:
>> Add a property to configure QUPv3 SE as SPI Device mode.
>>
>> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
>> ---
>> v2 -> v3:
>> - modified commit message to use device mode instead of slave mode
> Suitability or w/e of the property aside, I don't understand this.
> Why not change the *property*, which has far more visibility than the
> commit message, to use device rather than slave?
We are going use existing property spi-slave
>
> Chers,
> Conor.
>
>> ---
>>   Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
>> index 2e20ca313ec1..5c7d0293bbf7 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
>> @@ -66,6 +66,10 @@ properties:
>>     reg:
>>       maxItems: 1
>>   
>> +  qcom,slv-ctrl:
>> +    description: configure QUPv3 SE as Device mode
>> +    type: boolean
>> +
>>   required:
>>     - compatible
>>     - clocks
>> -- 
>> 2.17.1
>>