[PATCH][next] btrfs: remove redundant initialization of variables leaf and slot

Colin Ian King posted 1 patch 2 years, 7 months ago
fs/btrfs/tree-log.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH][next] btrfs: remove redundant initialization of variables leaf and slot
Posted by Colin Ian King 2 years, 7 months ago
The variables leaf and slot are initialized when declared but the values
assigned to them are never read as they are being re-assigned later on.
The initializations are redundant and can be removed. Cleans up clang
scan build warings:

fs/btrfs/tree-log.c:6797:25: warning: Value stored to 'leaf' during its
initialization is never read [deadcode.DeadStores]
fs/btrfs/tree-log.c:6798:7: warning: Value stored to 'slot' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/btrfs/tree-log.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 365a1cc0a3c3..8ad7e7e38d18 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -6794,8 +6794,8 @@ static int log_new_ancestors(struct btrfs_trans_handle *trans,
 
 	while (true) {
 		struct btrfs_fs_info *fs_info = root->fs_info;
-		struct extent_buffer *leaf = path->nodes[0];
-		int slot = path->slots[0];
+		struct extent_buffer *leaf;
+		int slot;
 		struct btrfs_key search_key;
 		struct inode *inode;
 		u64 ino;
-- 
2.39.2
Re: [PATCH][next] btrfs: remove redundant initialization of variables leaf and slot
Posted by David Sterba 2 years, 7 months ago
On Thu, Jun 22, 2023 at 08:54:30AM +0100, Colin Ian King wrote:
> The variables leaf and slot are initialized when declared but the values
> assigned to them are never read as they are being re-assigned later on.
> The initializations are redundant and can be removed. Cleans up clang
> scan build warings:
> 
> fs/btrfs/tree-log.c:6797:25: warning: Value stored to 'leaf' during its
> initialization is never read [deadcode.DeadStores]
> fs/btrfs/tree-log.c:6798:7: warning: Value stored to 'slot' during its
> initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Added to misc-next, thanks.