Hi!

This series adds support for the Cypress HX3 USB 3.0 family (2/3). For
now, it just contains the USB-related aspects and ignores the option to
connect it via i2c (3/3).

As the HX3 family operates with two power supplies, multiple power
supply support is implemented (1/3).

Thanks & best regards,
Benjamin

---
Changes in v7:
- 1/3: %ld -> %zu (thanks to lkp)
- Link to v6: https://lore.kernel.org/r/20230620-hx3-v6-0-6a1d6f8ce689@skidata.com

Changes in v6:
- 1/3: %d -> %ld (thanks to lkp) 
- Link to v5: https://lore.kernel.org/r/20230620-hx3-v5-0-319c9c4c846f@skidata.com

Changes in v5:
- 1/3: use ARRAY_SIZE(supply_names) for MAX_SUPPLIES (thanks to Alex)
- Link to v4: https://lore.kernel.org/r/20230620-hx3-v4-0-e56b3c6db60b@skidata.com

Changes in v4:
- 1/3: set num_supplies=1 for the existing hubs
- 1/3: drop duplicate num_supplies in onboard_hub struct
- 1/3: clarify connection between supply_names and MAX_SUPPLIES
- Link to v3: https://lore.kernel.org/r/20230620-hx3-v3-0-2acbc03ca949@skidata.com

Changes in v3:
- 1/3: fix nits mentioned by Matthias
- Link to v2: https://lore.kernel.org/r/20230620-hx3-v2-0-76a53434c713@skidata.com

Changes in v2:
- don't re-order by VID/PID (thanks to Matthias)
- 1/3: replace (err != 0) with (err)
- Link to v1: https://lore.kernel.org/r/20230620-hx3-v1-0-3a649b34c85b@skidata.com

---
Benjamin Bara (3):
      usb: misc: onboard-hub: support multiple power supplies
      usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family
      dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family

 .../devicetree/bindings/usb/cypress,hx3.yaml       | 77 ++++++++++++++++++++++
 drivers/usb/misc/onboard_usb_hub.c                 | 40 ++++++++---
 drivers/usb/misc/onboard_usb_hub.h                 | 14 ++++
 3 files changed, 123 insertions(+), 8 deletions(-)
---
base-commit: 45a3e24f65e90a047bef86f927ebdc4c710edaa1
change-id: 20230620-hx3-cb935b4fdd76

Best regards,
-- 
Benjamin Bara <benjamin.bara@skidata.com>

On Fri, Jun 23, 2023 at 09:28:11AM +0200, Benjamin Bara wrote:
> Hi!
> 
> This series adds support for the Cypress HX3 USB 3.0 family (2/3). For
> now, it just contains the USB-related aspects and ignores the option to
> connect it via i2c (3/3).
> 
> As the HX3 family operates with two power supplies, multiple power
> supply support is implemented (1/3).
> 
> Thanks & best regards,
> Benjamin
> 
> ---
> Changes in v7:
> - 1/3: %ld -> %zu (thanks to lkp)
> - Link to v6: https://lore.kernel.org/r/20230620-hx3-v6-0-6a1d6f8ce689@skidata.com

Wow, that's a lot of respins so quickly, please relax and take your time
and wait a few days before resending patch series as it causes
cross-reviews of old versions, which has happened many times here
already.

I'll wait for 6.5-rc1 to come out before looking at this again to give
everything some time to settle down.

thanks,

greg k-h

Hi greg and Krysztof,

On Fri, 23 Jun 2023 at 09:41, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> Please give some time before resending bigger (non-trivial) patches. One
> per day is usually enough. I still see some kbuild robot reports - from
> this or previous patchset, so are you sure you compile tested it on few
> different platforms?

On Fri, 23 Jun 2023 at 09:46, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Wow, that's a lot of respins so quickly, please relax and take your time
> and wait a few days before resending patch series as it causes
> cross-reviews of old versions, which has happened many times here
> already.
>
> I'll wait for 6.5-rc1 to come out before looking at this again to give
> everything some time to settle down.

Sorry for the spam, was a little stressed and wanted to get it done
before driving to Prague. Obviously was a stupid idea I will remember
for the future.

Best regards and please excuse the inconveniences. Won't happen again.
Benjamin

On 23/06/2023 09:28, Benjamin Bara wrote:
> Hi!
> 
> This series adds support for the Cypress HX3 USB 3.0 family (2/3). For
> now, it just contains the USB-related aspects and ignores the option to
> connect it via i2c (3/3).
> 
> As the HX3 family operates with two power supplies, multiple power
> supply support is implemented (1/3).
> 
> Thanks & best regards,
> Benjamin
> 
> ---
> Changes in v7:
> - 1/3: %ld -> %zu (thanks to lkp)
> - Link to v6: https://lore.kernel.org/r/20230620-hx3-v6-0-6a1d6f8ce689@skidata.com

Please give some time before resending bigger (non-trivial) patches. One
per day is usually enough. I still see some kbuild robot reports - from
this or previous patchset, so are you sure you compile tested it on few
different platforms?

Best regards,
Krzysztof