[PATCH v1 0/4] ASoC: remove copy of intlog10()

Andy Shevchenko posted 4 patches 2 years, 7 months ago
There is a newer version of this series
Documentation/driver-api/media/dtv-common.rst |  2 +-
drivers/media/dvb-core/Makefile               |  2 +-
drivers/media/dvb-frontends/af9013_priv.h     |  2 +-
drivers/media/dvb-frontends/af9033_priv.h     |  2 +-
drivers/media/dvb-frontends/cxd2820r_priv.h   |  2 +-
drivers/media/dvb-frontends/cxd2841er.c       |  2 +-
.../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c        |  2 +-
.../cxd2880/cxd2880_tnrdmd_dvbt_mon.c         |  2 +-
.../media/dvb-frontends/cxd2880/cxd2880_top.c |  2 +-
drivers/media/dvb-frontends/dib7000p.c        |  2 +-
drivers/media/dvb-frontends/dib8000.c         |  2 +-
drivers/media/dvb-frontends/dib9000.c         |  2 +-
drivers/media/dvb-frontends/drxk_hard.c       |  2 +-
drivers/media/dvb-frontends/lgdt3305.c        |  2 +-
drivers/media/dvb-frontends/lgdt3306a.c       |  2 +-
drivers/media/dvb-frontends/lgdt330x.c        |  2 +-
drivers/media/dvb-frontends/m88ds3103_priv.h  |  2 +-
drivers/media/dvb-frontends/mn88443x.c        |  2 +-
drivers/media/dvb-frontends/mn88472_priv.h    |  2 +-
drivers/media/dvb-frontends/mn88473_priv.h    |  2 +-
drivers/media/dvb-frontends/or51132.c         |  2 +-
drivers/media/dvb-frontends/or51211.c         |  2 +-
drivers/media/dvb-frontends/rtl2830_priv.h    |  2 +-
drivers/media/dvb-frontends/rtl2832_priv.h    |  2 +-
drivers/media/dvb-frontends/si2165.c          |  2 +-
drivers/media/dvb-frontends/stv0367.c         |  2 +-
drivers/media/dvb-frontends/tc90522.c         |  2 +-
drivers/media/dvb-frontends/tda10048.c        |  2 +-
include/{media/dvb_math.h => linux/int_log.h} | 18 +---
lib/math/Makefile                             |  2 +-
.../dvb-core/dvb_math.c => lib/math/int_log.c | 26 ++----
sound/soc/codecs/nau8825.c                    | 93 +------------------
32 files changed, 45 insertions(+), 150 deletions(-)
rename include/{media/dvb_math.h => linux/int_log.h} (63%)
rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%)
[PATCH v1 0/4] ASoC: remove copy of intlog10()
Posted by Andy Shevchenko 2 years, 7 months ago
The first three patches moves intlog10() to be available in entire
kernel. The last one removes copy of it in one driver. Besides already
good Lines of Code (LoC) statistics the upcoming users, if any, can
utilize the exported functions.

The series can be routed either via ASoC tree or media tree.

Note, int_log.h is separated from math.h due to licensing.
I dunno if we can mix two in a single header file. In any
case we may do it later on.

Andy Shevchenko (4):
  lib/math: Move dvb_math.c into lib/math/int_log.c
  lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense
  lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX
    identifier
  ASoC: nau8825: Replace copied'n'pasted intlog10()

 Documentation/driver-api/media/dtv-common.rst |  2 +-
 drivers/media/dvb-core/Makefile               |  2 +-
 drivers/media/dvb-frontends/af9013_priv.h     |  2 +-
 drivers/media/dvb-frontends/af9033_priv.h     |  2 +-
 drivers/media/dvb-frontends/cxd2820r_priv.h   |  2 +-
 drivers/media/dvb-frontends/cxd2841er.c       |  2 +-
 .../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c        |  2 +-
 .../cxd2880/cxd2880_tnrdmd_dvbt_mon.c         |  2 +-
 .../media/dvb-frontends/cxd2880/cxd2880_top.c |  2 +-
 drivers/media/dvb-frontends/dib7000p.c        |  2 +-
 drivers/media/dvb-frontends/dib8000.c         |  2 +-
 drivers/media/dvb-frontends/dib9000.c         |  2 +-
 drivers/media/dvb-frontends/drxk_hard.c       |  2 +-
 drivers/media/dvb-frontends/lgdt3305.c        |  2 +-
 drivers/media/dvb-frontends/lgdt3306a.c       |  2 +-
 drivers/media/dvb-frontends/lgdt330x.c        |  2 +-
 drivers/media/dvb-frontends/m88ds3103_priv.h  |  2 +-
 drivers/media/dvb-frontends/mn88443x.c        |  2 +-
 drivers/media/dvb-frontends/mn88472_priv.h    |  2 +-
 drivers/media/dvb-frontends/mn88473_priv.h    |  2 +-
 drivers/media/dvb-frontends/or51132.c         |  2 +-
 drivers/media/dvb-frontends/or51211.c         |  2 +-
 drivers/media/dvb-frontends/rtl2830_priv.h    |  2 +-
 drivers/media/dvb-frontends/rtl2832_priv.h    |  2 +-
 drivers/media/dvb-frontends/si2165.c          |  2 +-
 drivers/media/dvb-frontends/stv0367.c         |  2 +-
 drivers/media/dvb-frontends/tc90522.c         |  2 +-
 drivers/media/dvb-frontends/tda10048.c        |  2 +-
 include/{media/dvb_math.h => linux/int_log.h} | 18 +---
 lib/math/Makefile                             |  2 +-
 .../dvb-core/dvb_math.c => lib/math/int_log.c | 26 ++----
 sound/soc/codecs/nau8825.c                    | 93 +------------------
 32 files changed, 45 insertions(+), 150 deletions(-)
 rename include/{media/dvb_math.h => linux/int_log.h} (63%)
 rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%)

-- 
2.40.0.1.gaa8946217a0b
Re: [PATCH v1 0/4] ASoC: remove copy of intlog10()
Posted by Mauro Carvalho Chehab 2 years, 7 months ago
Em Mon, 19 Jun 2023 20:20:15 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu:

> The first three patches moves intlog10() to be available in entire
> kernel. The last one removes copy of it in one driver. Besides already
> good Lines of Code (LoC) statistics the upcoming users, if any, can
> utilize the exported functions.
> 
> The series can be routed either via ASoC tree or media tree.
> 
> Note, int_log.h is separated from math.h due to licensing.
> I dunno if we can mix two in a single header file. In any
> case we may do it later on.
> 
> Andy Shevchenko (4):
>   lib/math: Move dvb_math.c into lib/math/int_log.c
>   lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense
>   lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX
>     identifier
>   ASoC: nau8825: Replace copied'n'pasted intlog10()

It probably makes sense to apply it at ASoC tree, as the relevant
change is there.

I have just one small nit on patch 1/4, which should be trivial to
solve. Once done, feel free to merge it with  my ack:

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> 
>  Documentation/driver-api/media/dtv-common.rst |  2 +-
>  drivers/media/dvb-core/Makefile               |  2 +-
>  drivers/media/dvb-frontends/af9013_priv.h     |  2 +-
>  drivers/media/dvb-frontends/af9033_priv.h     |  2 +-
>  drivers/media/dvb-frontends/cxd2820r_priv.h   |  2 +-
>  drivers/media/dvb-frontends/cxd2841er.c       |  2 +-
>  .../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c        |  2 +-
>  .../cxd2880/cxd2880_tnrdmd_dvbt_mon.c         |  2 +-
>  .../media/dvb-frontends/cxd2880/cxd2880_top.c |  2 +-
>  drivers/media/dvb-frontends/dib7000p.c        |  2 +-
>  drivers/media/dvb-frontends/dib8000.c         |  2 +-
>  drivers/media/dvb-frontends/dib9000.c         |  2 +-
>  drivers/media/dvb-frontends/drxk_hard.c       |  2 +-
>  drivers/media/dvb-frontends/lgdt3305.c        |  2 +-
>  drivers/media/dvb-frontends/lgdt3306a.c       |  2 +-
>  drivers/media/dvb-frontends/lgdt330x.c        |  2 +-
>  drivers/media/dvb-frontends/m88ds3103_priv.h  |  2 +-
>  drivers/media/dvb-frontends/mn88443x.c        |  2 +-
>  drivers/media/dvb-frontends/mn88472_priv.h    |  2 +-
>  drivers/media/dvb-frontends/mn88473_priv.h    |  2 +-
>  drivers/media/dvb-frontends/or51132.c         |  2 +-
>  drivers/media/dvb-frontends/or51211.c         |  2 +-
>  drivers/media/dvb-frontends/rtl2830_priv.h    |  2 +-
>  drivers/media/dvb-frontends/rtl2832_priv.h    |  2 +-
>  drivers/media/dvb-frontends/si2165.c          |  2 +-
>  drivers/media/dvb-frontends/stv0367.c         |  2 +-
>  drivers/media/dvb-frontends/tc90522.c         |  2 +-
>  drivers/media/dvb-frontends/tda10048.c        |  2 +-
>  include/{media/dvb_math.h => linux/int_log.h} | 18 +---
>  lib/math/Makefile                             |  2 +-
>  .../dvb-core/dvb_math.c => lib/math/int_log.c | 26 ++----
>  sound/soc/codecs/nau8825.c                    | 93 +------------------
>  32 files changed, 45 insertions(+), 150 deletions(-)
>  rename include/{media/dvb_math.h => linux/int_log.h} (63%)
>  rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%)
>