[PATCH net-next] dt-bindings: net: micrel,ks8851: allow SPI device properties

Krzysztof Kozlowski posted 1 patch 2 years, 7 months ago
Documentation/devicetree/bindings/net/micrel,ks8851.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH net-next] dt-bindings: net: micrel,ks8851: allow SPI device properties
Posted by Krzysztof Kozlowski 2 years, 7 months ago
The Micrel KS8851 can be attached to SPI or parallel bus and the
difference is expressed in compatibles.  Allow common SPI properties
when this is a SPI variant and narrow the parallel memory bus properties
to the second case.

This fixes dtbs_check warning:

  qcom-msm8960-cdp.dtb: ethernet@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/micrel,ks8851.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/micrel,ks8851.yaml b/Documentation/devicetree/bindings/net/micrel,ks8851.yaml
index b44d83554ef5..b726c6e14633 100644
--- a/Documentation/devicetree/bindings/net/micrel,ks8851.yaml
+++ b/Documentation/devicetree/bindings/net/micrel,ks8851.yaml
@@ -44,13 +44,13 @@ required:
 
 allOf:
   - $ref: ethernet-controller.yaml#
-  - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
   - if:
       properties:
         compatible:
           contains:
             const: micrel,ks8851
     then:
+      $ref: /schemas/spi/spi-peripheral-props.yaml#
       properties:
         reg:
           maxItems: 1
@@ -60,6 +60,7 @@ allOf:
           contains:
             const: micrel,ks8851-mll
     then:
+      $ref: /schemas/memory-controllers/mc-peripheral-props.yaml#
       properties:
         reg:
           minItems: 2
-- 
2.34.1
Re: [PATCH net-next] dt-bindings: net: micrel,ks8851: allow SPI device properties
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 7 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 19 Jun 2023 19:01:34 +0200 you wrote:
> The Micrel KS8851 can be attached to SPI or parallel bus and the
> difference is expressed in compatibles.  Allow common SPI properties
> when this is a SPI variant and narrow the parallel memory bus properties
> to the second case.
> 
> This fixes dtbs_check warning:
> 
> [...]

Here is the summary with links:
  - [net-next] dt-bindings: net: micrel,ks8851: allow SPI device properties
    https://git.kernel.org/netdev/net-next/c/1ca09f5746ed

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] dt-bindings: net: micrel,ks8851: allow SPI device properties
Posted by Conor Dooley 2 years, 7 months ago
On Mon, Jun 19, 2023 at 07:01:34PM +0200, Krzysztof Kozlowski wrote:
> The Micrel KS8851 can be attached to SPI or parallel bus and the
> difference is expressed in compatibles.  Allow common SPI properties
> when this is a SPI variant and narrow the parallel memory bus properties
> to the second case.
> 
> This fixes dtbs_check warning:
> 
>   qcom-msm8960-cdp.dtb: ethernet@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.