[v2] GPIO-based hotplug i2c bus

[PATCH v2 0/2] GPIO-based hotplug i2c bus

Posted by Svyatoslav Ryhel 2 years, 7 months ago

ASUS Transformers require this driver for proper work with their dock.
Dock is controlled by EC and its presence is detected by a GPIO.

---
Changes in v2:
- adjusted documentation
---

Michał Mirosław (1):
  i2c: Add GPIO-based hotplug gate

Svyatoslav Ryhel (1):
  dt-bindings: i2c: add binding for i2c-hotplug-gpio

 .../bindings/i2c/i2c-hotplug-gpio.yaml        |  65 +++++
 drivers/i2c/Kconfig                           |  11 +
 drivers/i2c/Makefile                          |   1 +
 drivers/i2c/i2c-hotplug-gpio.c                | 266 ++++++++++++++++++
 4 files changed, 343 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-hotplug-gpio.yaml
 create mode 100644 drivers/i2c/i2c-hotplug-gpio.c

-- 
2.39.2

Re: [PATCH v2 0/2] GPIO-based hotplug i2c bus

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 19/06/2023 17:37, Svyatoslav Ryhel wrote:
> ASUS Transformers require this driver for proper work with their dock.
> Dock is controlled by EC and its presence is detected by a GPIO.
> 
> ---
> Changes in v2:
> - adjusted documentation

This is too generic. Everything can be adjustment. Be precise what you
did here. What changed?

Best regards,
Krzysztof

Re: [PATCH v2 0/2] GPIO-based hotplug i2c bus

Posted by Svyatoslav Ryhel 2 years, 7 months ago

пн, 19 черв. 2023 р. о 18:49 Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> пише:
>
> On 19/06/2023 17:37, Svyatoslav Ryhel wrote:
> > ASUS Transformers require this driver for proper work with their dock.
> > Dock is controlled by EC and its presence is detected by a GPIO.
> >
> > ---
> > Changes in v2:
> > - adjusted documentation
>
> This is too generic. Everything can be adjustment. Be precise what you
> did here. What changed?
>

Everything that you asked for.

> Best regards,
> Krzysztof
>

Re: [PATCH v2 0/2] GPIO-based hotplug i2c bus

Posted by Andi Shyti 2 years, 7 months ago

Hi Svyatoslav,

On Mon, Jun 19, 2023 at 06:52:50PM +0300, Svyatoslav Ryhel wrote:
> пн, 19 черв. 2023 р. о 18:49 Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> пише:
> >
> > On 19/06/2023 17:37, Svyatoslav Ryhel wrote:
> > > ASUS Transformers require this driver for proper work with their dock.
> > > Dock is controlled by EC and its presence is detected by a GPIO.
> > >
> > > ---
> > > Changes in v2:
> > > - adjusted documentation
> >
> > This is too generic. Everything can be adjustment. Be precise what you
> > did here. What changed?
> >
> 
> Everything that you asked for.

please list all the changes you made trying to be as more
specific as you can.

You make life to reviewers easier.

Thanks,
Andi

Re: [PATCH v2 0/2] GPIO-based hotplug i2c bus

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On 19/06/2023 17:52, Svyatoslav Ryhel wrote:
> пн, 19 черв. 2023 р. о 18:49 Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> пише:
>>
>> On 19/06/2023 17:37, Svyatoslav Ryhel wrote:
>>> ASUS Transformers require this driver for proper work with their dock.
>>> Dock is controlled by EC and its presence is detected by a GPIO.
>>>
>>> ---
>>> Changes in v2:
>>> - adjusted documentation
>>
>> This is too generic. Everything can be adjustment. Be precise what you
>> did here. What changed?
>>
> 
> Everything that you asked for.

And how other people can know it? That's not a proper changelog.

What changed? If you are going to ignore writing proper changelogs, I am
going to ignore patches.

Best regards,
Krzysztof