media: s5k5baf: Add MODULE_FIRMWARE macro

[PATCH] media: s5k5baf: Add MODULE_FIRMWARE macro

Posted by Juerg Haefliger 2 years, 7 months ago

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 drivers/media/i2c/s5k5baf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c
index 960fbf6428ea..69a3bad54530 100644
--- a/drivers/media/i2c/s5k5baf.c
+++ b/drivers/media/i2c/s5k5baf.c
@@ -2031,3 +2031,5 @@ module_i2c_driver(s5k5baf_i2c_driver);
 MODULE_DESCRIPTION("Samsung S5K5BAF(X) UXGA camera driver");
 MODULE_AUTHOR("Andrzej Hajda <a.hajda@samsung.com>");
 MODULE_LICENSE("GPL v2");
+
+MODULE_FIRMWARE(S5K5BAF_FW_FILENAME);
-- 
2.37.2

Re: [PATCH] media: s5k5baf: Add MODULE_FIRMWARE macro

Posted by Andrzej Hajda 2 years, 7 months ago


On 16.06.2023 14:01, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>

Acked-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej
> ---
>   drivers/media/i2c/s5k5baf.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c
> index 960fbf6428ea..69a3bad54530 100644
> --- a/drivers/media/i2c/s5k5baf.c
> +++ b/drivers/media/i2c/s5k5baf.c
> @@ -2031,3 +2031,5 @@ module_i2c_driver(s5k5baf_i2c_driver);
>   MODULE_DESCRIPTION("Samsung S5K5BAF(X) UXGA camera driver");
>   MODULE_AUTHOR("Andrzej Hajda <a.hajda@samsung.com>");
>   MODULE_LICENSE("GPL v2");
> +
> +MODULE_FIRMWARE(S5K5BAF_FW_FILENAME);