selftests/ftrace: Add test dependency

[PATCH] selftests/ftrace: Add test dependency

Posted by Thibault Ferrante 2 years, 7 months ago

test_duplicates miss a running dependency and leads to test failures
on kernel with specific configuration.

Signed-off-by: Thibault Ferrante <thibault.ferrante@canonical.com>
---
 .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
index d3a79da215c8..0b5e4543e70b 100644
--- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
+++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
@@ -1,7 +1,7 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Generic dynamic event - check if duplicate events are caught
-# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
+# requires: dynamic_events events/syscalls/sys_enter_openat "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
 
 echo 0 > events/enable
 
-- 
2.39.2

Re: [PATCH] selftests/ftrace: Add test dependency

Posted by Steven Rostedt 1 month, 2 weeks ago

On Wed, 14 Jun 2023 12:50:31 +0200
Thibault Ferrante <thibault.ferrante@canonical.com> wrote:

> test_duplicates miss a running dependency and leads to test failures
> on kernel with specific configuration.
> 

Found another old patch. But this one still needs review.

Masami, does this look good to you?

-- Steve


> Signed-off-by: Thibault Ferrante <thibault.ferrante@canonical.com>
> ---
>  .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> index d3a79da215c8..0b5e4543e70b 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: Generic dynamic event - check if duplicate events are caught
> -# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events events/syscalls/sys_enter_openat "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>  
>  echo 0 > events/enable
>