[v1] Add common RDP dtsi file for ipq9574

[PATCH 2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons

Posted by Anusha Rao 2 years, 8 months ago

Add support for wps buttons on GPIO 37.

Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
---
 .../boot/dts/qcom/ipq9574-rdp-common.dtsi     | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index 999902bc70bd..fd5326dc1773 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -8,6 +8,8 @@
 
 /dts-v1/;
 
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include "ipq9574.dtsi"
 
 / {
@@ -18,6 +20,20 @@
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&gpio_keys_default>;
+		pinctrl-names = "default";
+
+		button-wps {
+			label = "wps";
+			linux,code = <KEY_WPS_BUTTON>;
+			gpios = <&tlmm 37 GPIO_ACTIVE_LOW>;
+			linux,input-type = <1>;
+			debounce-interval = <60>;
+		};
+	};
 };
 
 &blsp1_spi0 {
@@ -114,6 +130,13 @@
 		drive-strength = <8>;
 		bias-disable;
 	};
+
+	gpio_keys_default: gpio-keys-default-state {
+		pins = "gpio37";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-pull-up;
+	};
 };
 
 &xo_board_clk {
-- 
2.17.1

Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons

Posted by Konrad Dybcio 2 years, 8 months ago


On 14.06.2023 10:50, Anusha Rao wrote:
> Add support for wps buttons on GPIO 37.
> 
> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
> ---
>  .../boot/dts/qcom/ipq9574-rdp-common.dtsi     | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index 999902bc70bd..fd5326dc1773 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -8,6 +8,8 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>  #include "ipq9574.dtsi"
>  
>  / {
> @@ -18,6 +20,20 @@
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&gpio_keys_default>;
> +		pinctrl-names = "default";
> +
> +		button-wps {
> +			label = "wps";
> +			linux,code = <KEY_WPS_BUTTON>;
> +			gpios = <&tlmm 37 GPIO_ACTIVE_LOW>;
> +			linux,input-type = <1>;
This line is unnecessary, it's set to 'key' by default. With that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +			debounce-interval = <60>;
> +		};
> +	};
>  };
>  
>  &blsp1_spi0 {
> @@ -114,6 +130,13 @@
>  		drive-strength = <8>;
>  		bias-disable;
>  	};
> +
> +	gpio_keys_default: gpio-keys-default-state {
> +		pins = "gpio37";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-pull-up;
> +	};
>  };
>  
>  &xo_board_clk {

Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons

Posted by Anusha Canchi 2 years, 7 months ago


On 6/14/2023 4:12 PM, Konrad Dybcio wrote:
>
> On 14.06.2023 10:50, Anusha Rao wrote:
>> Add support for wps buttons on GPIO 37.
>>
>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>> ---
>>   .../boot/dts/qcom/ipq9574-rdp-common.dtsi     | 23 +++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> index 999902bc70bd..fd5326dc1773 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> @@ -8,6 +8,8 @@
>>   
>>   /dts-v1/;
>>   
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>>   #include "ipq9574.dtsi"
>>   
>>   / {
>> @@ -18,6 +20,20 @@
>>   	chosen {
>>   		stdout-path = "serial0:115200n8";
>>   	};
>> +
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +		pinctrl-0 = <&gpio_keys_default>;
>> +		pinctrl-names = "default";
>> +
>> +		button-wps {
>> +			label = "wps";
>> +			linux,code = <KEY_WPS_BUTTON>;
>> +			gpios = <&tlmm 37 GPIO_ACTIVE_LOW>;
>> +			linux,input-type = <1>;
> This line is unnecessary, it's set to 'key' by default. With that:
Okay, will address in the next patch.

Thanks,
Anusha
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad
>> +			debounce-interval = <60>;
>> +		};
>> +	};
>>   };
>>   
>>   &blsp1_spi0 {
>> @@ -114,6 +130,13 @@
>>   		drive-strength = <8>;
>>   		bias-disable;
>>   	};
>> +
>> +	gpio_keys_default: gpio-keys-default-state {
>> +		pins = "gpio37";
>> +		function = "gpio";
>> +		drive-strength = <8>;
>> +		bias-pull-up;
>> +	};
>>   };
>>   
>>   &xo_board_clk {