clk: meson: a1: Staticize rtc clk

[PATCH] clk: meson: a1: Staticize rtc clk

Posted by Stephen Boyd 2 years, 7 months ago

Sparse rightly complains that this symbol is supposed to be static.

Cc: Jian Hu <jian.hu@amlogic.com>
Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/meson/a1-peripherals.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
index b320134fefeb..75dfae210fe5 100644
--- a/drivers/clk/meson/a1-peripherals.c
+++ b/drivers/clk/meson/a1-peripherals.c
@@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
 	},
 };
 
-struct clk_regmap rtc = {
+static struct clk_regmap rtc = {
 	.data = &(struct clk_regmap_gate_data){
 		.offset = RTC_BY_OSCIN_CTRL0,
 		.bit_idx = 30,
-- 
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

Re: [PATCH] clk: meson: a1: Staticize rtc clk

Posted by Stephen Boyd 2 years, 7 months ago

Quoting Stephen Boyd (2023-06-12 11:23:32)
> Sparse rightly complains that this symbol is supposed to be static.
> 
> Cc: Jian Hu <jian.hu@amlogic.com>
> Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---

Applied to clk-next

Re: [PATCH] clk: meson: a1: Staticize rtc clk

Posted by Martin Blumenstingl 2 years, 7 months ago

On Mon, Jun 12, 2023 at 8:23 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <jian.hu@amlogic.com>
> Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Thanks for providing a fix so quickly!

Jerome, I think it's easiest for Stephen to apply this patch directly
to the clock tree.
In my opinion there's no reason against this since our own patch queue is empty.



Best regards,
Martin

Re: [PATCH] clk: meson: a1: Staticize rtc clk

Posted by Jerome Brunet 2 years, 7 months ago

On Mon 12 Jun 2023 at 11:23, Stephen Boyd <sboyd@kernel.org> wrote:

> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <jian.hu@amlogic.com>
> Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

Sorry this got through.

> ---
>  drivers/clk/meson/a1-peripherals.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
> index b320134fefeb..75dfae210fe5 100644
> --- a/drivers/clk/meson/a1-peripherals.c
> +++ b/drivers/clk/meson/a1-peripherals.c
> @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
>  	},
>  };
>  
> -struct clk_regmap rtc = {
> +static struct clk_regmap rtc = {
>  	.data = &(struct clk_regmap_gate_data){
>  		.offset = RTC_BY_OSCIN_CTRL0,
>  		.bit_idx = 30,