[PATCH] Documentation: virt: correct location of haltpoll module params

Randy Dunlap posted 1 patch 2 years, 8 months ago
Documentation/virt/guest-halt-polling.rst |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Documentation: virt: correct location of haltpoll module params
Posted by Randy Dunlap 2 years, 8 months ago
Module parameters are located in sysfs, not debugfs, so correct the
statement.

Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 Documentation/virt/guest-halt-polling.rst |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
--- a/Documentation/virt/guest-halt-polling.rst
+++ b/Documentation/virt/guest-halt-polling.rst
@@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
 
 Default: Y
 
-The module parameters can be set from the debugfs files in::
+The module parameters can be set from the sysfs files in::
 
 	/sys/module/haltpoll/parameters/
Re: [PATCH] Documentation: virt: correct location of haltpoll module params
Posted by Marcelo Tosatti 2 years, 7 months ago
On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> Module parameters are located in sysfs, not debugfs, so correct the
> statement.
> 
> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---
>  Documentation/virt/guest-halt-polling.rst |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>  
>  Default: Y
>  
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>  
>  	/sys/module/haltpoll/parameters/
>  
> 
> 

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Re: [PATCH] Documentation: virt: correct location of haltpoll module params
Posted by Jonathan Corbet 2 years, 7 months ago
Marcelo Tosatti <mtosatti@redhat.com> writes:

> On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
>> Module parameters are located in sysfs, not debugfs, so correct the
>> statement.
>> 
>> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Marcelo Tosatti <mtosatti@redhat.com>
>> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: linux-doc@vger.kernel.org
>> ---
>>  Documentation/virt/guest-halt-polling.rst |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
>> --- a/Documentation/virt/guest-halt-polling.rst
>> +++ b/Documentation/virt/guest-halt-polling.rst
>> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>>  
>>  Default: Y
>>  
>> -The module parameters can be set from the debugfs files in::
>> +The module parameters can be set from the sysfs files in::
>>  
>>  	/sys/module/haltpoll/parameters/
>>  
>> 
>> 
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

I'm not sure why you're offering a signoff for Randy's patch...?

In any case, I've taken this as an ack and applied it.

Thanks,

jon
Re: [PATCH] Documentation: virt: correct location of haltpoll module params
Posted by Bagas Sanjaya 2 years, 8 months ago
On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>  
>  Default: Y
>  
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>  
>  	/sys/module/haltpoll/parameters/
>  

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara