Documentation/hwmon/hwmon-kernel-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Use devm_hwmon_device_register_with_info to replace
hwmon_device_register_with_info in description of
devm_hwmon_device_unregister.
Signed-off-by: Yongsheng Yang <iyysheng@gmail.com>
---
Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
index c2d1e0299d8d..6cacf7daf25c 100644
--- a/Documentation/hwmon/hwmon-kernel-api.rst
+++ b/Documentation/hwmon/hwmon-kernel-api.rst
@@ -66,7 +66,7 @@ hwmon_device_register_with_info.
devm_hwmon_device_unregister does not normally have to be called. It is only
needed for error handling, and only needed if the driver probe fails after
-the call to hwmon_device_register_with_info and if the automatic (device
+the call to devm_hwmon_device_register_with_info and if the automatic (device
managed) removal would be too late.
All supported hwmon device registration functions only accept valid device
--
2.37.1
On Fri, Jun 09, 2023 at 11:55:10AM +0400, Yongsheng Yang wrote: > Use devm_hwmon_device_register_with_info to replace > hwmon_device_register_with_info in description of > devm_hwmon_device_unregister. > You didn't add () to function names, but I guess it is better to do that in a separate patch anyway. Applied. Thanks, Guenter > Signed-off-by: Yongsheng Yang <iyysheng@gmail.com> > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> > --- > Documentation/hwmon/hwmon-kernel-api.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst > index c2d1e0299d8d..6cacf7daf25c 100644 > --- a/Documentation/hwmon/hwmon-kernel-api.rst > +++ b/Documentation/hwmon/hwmon-kernel-api.rst > @@ -66,7 +66,7 @@ hwmon_device_register_with_info. > > devm_hwmon_device_unregister does not normally have to be called. It is only > needed for error handling, and only needed if the driver probe fails after > -the call to hwmon_device_register_with_info and if the automatic (device > +the call to devm_hwmon_device_register_with_info and if the automatic (device > managed) removal would be too late. > > All supported hwmon device registration functions only accept valid device
> On Fri, Jun 09, 2023 at 11:55:10AM +0400, Yongsheng Yang wrote: > > Use devm_hwmon_device_register_with_info to replace > > hwmon_device_register_with_info in description of > > devm_hwmon_device_unregister. > > > > You didn't add () to function names, but I guess it is better to do that > in a separate patch anyway. > > Applied. > > Thanks, > Guenter > Ok, I just add () to function names in commit message title. I will add () to function names releate in the whole commit message. Then I will post the updated version. Thanks Yongsheng > > Signed-off-by: Yongsheng Yang <iyysheng@gmail.com> > > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> > > --- > > Documentation/hwmon/hwmon-kernel-api.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst > > index c2d1e0299d8d..6cacf7daf25c 100644 > > --- a/Documentation/hwmon/hwmon-kernel-api.rst > > +++ b/Documentation/hwmon/hwmon-kernel-api.rst > > @@ -66,7 +66,7 @@ hwmon_device_register_with_info. > > > > devm_hwmon_device_unregister does not normally have to be called. It is only > > needed for error handling, and only needed if the driver probe fails after > > -the call to hwmon_device_register_with_info and if the automatic (device > > +the call to devm_hwmon_device_register_with_info and if the automatic (device > > managed) removal would be too late. > > > > All supported hwmon device registration functions only accept valid device
On 6/9/23 14:55, Yongsheng Yang wrote: > diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst > index c2d1e0299d8d..6cacf7daf25c 100644 > --- a/Documentation/hwmon/hwmon-kernel-api.rst > +++ b/Documentation/hwmon/hwmon-kernel-api.rst > @@ -66,7 +66,7 @@ hwmon_device_register_with_info. > > devm_hwmon_device_unregister does not normally have to be called. It is only > needed for error handling, and only needed if the driver probe fails after > -the call to hwmon_device_register_with_info and if the automatic (device > +the call to devm_hwmon_device_register_with_info and if the automatic (device > managed) removal would be too late. > > All supported hwmon device registration functions only accept valid device LGTM, thanks! Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> -- An old man doll... just what I always wanted! - Clara
© 2016 - 2026 Red Hat, Inc.