The ili9882t touch screen chip same as Elan eKTH6915 controller
has a reset gpio. The difference is that ili9882t needs to use
vccio-supply instead of vcc33-supply. Doug's series[1] allows panels
and touchscreens to power on/off together, let's add a phandle for this.
[1]: https://lore.kernel.org/r/20230607215224.2067679-1-dianders@chromium.org
Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
---
.../bindings/input/ilitek,ili9882t.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml
diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml
new file mode 100644
index 000000000000..89584264d6a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/ilitek,ili9882t.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ilitek ili9882t touchscreen controller
+
+maintainers:
+ - Dmitry Torokhov <dmitry.torokhov@gmail.com>
+
+description:
+ Supports the Ilitek ili9882t touchscreen controller.
+ This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
+
+allOf:
+ - $ref: /schemas/input/touchscreen/touchscreen.yaml#
+
+properties:
+ compatible:
+ const: ilitek,ili9882t
+
+ reg:
+ const: 0x41
+
+ interrupts:
+ maxItems: 1
+
+ panel: true
+
+ reset-gpios:
+ maxItems: 1
+ description: Reset GPIO.
+
+
+ vccio-supply:
+ description: The 1.8V supply to the touchscreen.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - vccio-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ touchscreen: touchscreen@41 {
+ compatible = "ilitek,ili9882t";
+ reg = <0x41>;
+
+ interrupt-parent = <&pio>;
+ interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
+
+ reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
+ vccio-supply = <&mt6366_vio18_reg>;
+ };
+ };
--
2.25.1On 08/06/2023 15:01, Cong Yang wrote: > The ili9882t touch screen chip same as Elan eKTH6915 controller > has a reset gpio. The difference is that ili9882t needs to use > vccio-supply instead of vcc33-supply. Doug's series[1] allows panels > and touchscreens to power on/off together, let's add a phandle for this. > > [1]: https://lore.kernel.org/r/20230607215224.2067679-1-dianders@chromium.org > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > --- > .../bindings/input/ilitek,ili9882t.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > > diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > new file mode 100644 > index 000000000000..89584264d6a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/ilitek,ili9882t.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ili9882t touchscreen controller > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@gmail.com> This usually should not be subsystem maintainer. > + > +description: > + Supports the Ilitek ili9882t touchscreen controller. > + This touchscreen controller uses the i2c-hid protocol with a reset GPIO. > + > +allOf: > + - $ref: /schemas/input/touchscreen/touchscreen.yaml# > + > +properties: > + compatible: > + const: ilitek,ili9882t > + > + reg: > + const: 0x41 > + > + interrupts: > + maxItems: 1 > + > + panel: true > + > + reset-gpios: > + maxItems: 1 > + description: Reset GPIO. > + > + Just one blank line. > + vccio-supply: > + description: The 1.8V supply to the touchscreen. > + > +required: > + - compatible > + - reg > + - interrupts > + - vccio-supply > + > +additionalProperties: false Why do you disallow all properties from toouchscreen.yaml? Aren't they applicable? Best regards, Krzysztof
Hi, On Fri, Jun 9, 2023 at 8:50 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > + vccio-supply: > > + description: The 1.8V supply to the touchscreen. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - vccio-supply > > + > > +additionalProperties: false > > Why do you disallow all properties from toouchscreen.yaml? Aren't they > applicable? This matches what hid-over-i2c.yaml does. It only picks `touchscreen-inverted-x` and `touchscreen-inverted-y` from the common file, which aren't needed here. I assume that the rest of the things from the common file can be probed using the i2c-hid protocol? -Doug
On 09/06/2023 17:56, Doug Anderson wrote: > Hi, > > On Fri, Jun 9, 2023 at 8:50 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >>> + vccio-supply: >>> + description: The 1.8V supply to the touchscreen. >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - vccio-supply >>> + >>> +additionalProperties: false >> >> Why do you disallow all properties from toouchscreen.yaml? Aren't they >> applicable? > > This matches what hid-over-i2c.yaml does. It only picks > `touchscreen-inverted-x` and `touchscreen-inverted-y` from the common > file, which aren't needed here. I assume that the rest of the things > from the common file can be probed using the i2c-hid protocol? OK Best regards, Krzysztof
Hi,
On Thu, Jun 8, 2023 at 6:02 AM Cong Yang
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/ilitek,ili9882t.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ilitek ili9882t touchscreen controller
> +
> +maintainers:
> + - Dmitry Torokhov <dmitry.torokhov@gmail.com>
Has Dmitry agreed to be the maintainer here? Traditionally when adding
a new file one lists themselves.
> +description:
> + Supports the Ilitek ili9882t touchscreen controller.
> + This touchscreen controller uses the i2c-hid protocol with a reset GPIO.
> +
> +allOf:
> + - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> + compatible:
> + const: ilitek,ili9882t
> +
> + reg:
> + const: 0x41
> +
> + interrupts:
> + maxItems: 1
> +
> + panel: true
> +
> + reset-gpios:
> + maxItems: 1
> + description: Reset GPIO.
> +
> +
> + vccio-supply:
> + description: The 1.8V supply to the touchscreen.
Why two blank lines between reset-gpios and vccio-supply?
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - vccio-supply
I think you want "panel" as a required property too, right?
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen: touchscreen@41 {
> + compatible = "ilitek,ili9882t";
> + reg = <0x41>;
> +
> + interrupt-parent = <&pio>;
> + interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
> +
> + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> + vccio-supply = <&mt6366_vio18_reg>;
...and "panel" would also need to go in the above example.
© 2016 - 2026 Red Hat, Inc.