[v1] New metricgroup output in perf stat default mode

[PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

Posted by kan.liang@linux.intel.com 2 years, 8 months ago

From: Kan Liang <kan.liang@linux.intel.com>

Add the default tags for ARM as well.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: John Garry <john.g.garry@oracle.com>
---
 tools/perf/pmu-events/arch/arm64/sbsa.json | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json
index f678c37ea9c3..f90b338261ac 100644
--- a/tools/perf/pmu-events/arch/arm64/sbsa.json
+++ b/tools/perf/pmu-events/arch/arm64/sbsa.json
@@ -2,28 +2,32 @@
     {
         "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)",
         "BriefDescription": "Frontend bound L1 topdown metric",
-        "MetricGroup": "TopdownL1",
+        "DefaultMetricgroupName": "TopdownL1",
+        "MetricGroup": "Default;TopdownL1",
         "MetricName": "frontend_bound",
         "ScaleUnit": "100%"
     },
     {
         "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
         "BriefDescription": "Bad speculation L1 topdown metric",
-        "MetricGroup": "TopdownL1",
+        "DefaultMetricgroupName": "TopdownL1",
+        "MetricGroup": "Default;TopdownL1",
         "MetricName": "bad_speculation",
         "ScaleUnit": "100%"
     },
     {
         "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
         "BriefDescription": "Retiring L1 topdown metric",
-        "MetricGroup": "TopdownL1",
+        "DefaultMetricgroupName": "TopdownL1",
+        "MetricGroup": "Default;TopdownL1",
         "MetricName": "retiring",
         "ScaleUnit": "100%"
     },
     {
         "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)",
         "BriefDescription": "Backend Bound L1 topdown metric",
-        "MetricGroup": "TopdownL1",
+        "DefaultMetricgroupName": "TopdownL1",
+        "MetricGroup": "Default;TopdownL1",
         "MetricName": "backend_bound",
         "ScaleUnit": "100%"
     }
-- 
2.35.1

Re: [PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

Posted by John Garry 2 years, 7 months ago

On 07/06/2023 17:26, kan.liang@linux.intel.com wrote:
> From: Kan Liang<kan.liang@linux.intel.com>
> 
> Add the default tags for ARM as well.
> 
> Signed-off-by: Kan Liang<kan.liang@linux.intel.com>
> Cc: Jing Zhang<renyu.zj@linux.alibaba.com>
> Cc: John Garry<john.g.garry@oracle.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>

But does pmu-events/arch/arm64/hisilicon/hip08/metrics.json need to be 
fixed up as well?

Re: [PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

Posted by Liang, Kan 2 years, 7 months ago


On 2023-06-14 10:30 a.m., John Garry wrote:
> On 07/06/2023 17:26, kan.liang@linux.intel.com wrote:
>> From: Kan Liang<kan.liang@linux.intel.com>
>>
>> Add the default tags for ARM as well.
>>
>> Signed-off-by: Kan Liang<kan.liang@linux.intel.com>
>> Cc: Jing Zhang<renyu.zj@linux.alibaba.com>
>> Cc: John Garry<john.g.garry@oracle.com>
> 
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> 
> But does pmu-events/arch/arm64/hisilicon/hip08/metrics.json need to be
> fixed up as well?

The patch has been added in V4. Please take a look.

https://lore.kernel.org/lkml/20230616031420.3751973-6-kan.liang@linux.intel.com/

Thanks,
Kan

Re: [PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

Posted by Ian Rogers 2 years, 7 months ago

On Wed, Jun 7, 2023 at 9:27 AM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Add the default tags for ARM as well.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
> Cc: John Garry <john.g.garry@oracle.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/pmu-events/arch/arm64/sbsa.json | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json
> index f678c37ea9c3..f90b338261ac 100644
> --- a/tools/perf/pmu-events/arch/arm64/sbsa.json
> +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json
> @@ -2,28 +2,32 @@
>      {
>          "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)",
>          "BriefDescription": "Frontend bound L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "frontend_bound",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
>          "BriefDescription": "Bad speculation L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "bad_speculation",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
>          "BriefDescription": "Retiring L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "retiring",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)",
>          "BriefDescription": "Backend Bound L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "backend_bound",
>          "ScaleUnit": "100%"
>      }
> --
> 2.35.1
>

Re: [PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

Posted by Arnaldo Carvalho de Melo 2 years, 7 months ago

Em Tue, Jun 13, 2023 at 12:45:10PM -0700, Ian Rogers escreveu:
> On Wed, Jun 7, 2023 at 9:27 AM <kan.liang@linux.intel.com> wrote:
> >
> > From: Kan Liang <kan.liang@linux.intel.com>
> >
> > Add the default tags for ARM as well.
> >
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> > Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
> > Cc: John Garry <john.g.garry@oracle.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/pmu-events/arch/arm64/sbsa.json | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json
> > index f678c37ea9c3..f90b338261ac 100644
> > --- a/tools/perf/pmu-events/arch/arm64/sbsa.json
> > +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json
> > @@ -2,28 +2,32 @@
> >      {
> >          "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)",
> >          "BriefDescription": "Frontend bound L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "frontend_bound",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
> >          "BriefDescription": "Bad speculation L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "bad_speculation",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
> >          "BriefDescription": "Retiring L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "retiring",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)",
> >          "BriefDescription": "Backend Bound L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "backend_bound",
> >          "ScaleUnit": "100%"
> >      }
> > --
> > 2.35.1
> >

-- 

- Arnaldo

[PATCH 1/8] perf metric: Fix no group check
[PATCH 2/8] perf evsel: Fix the annotation for hardware events on hybrid
[PATCH 3/8] perf metric: JSON flag to default metric group
[PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics
[PATCH 5/8] perf stat,jevents: Introduce Default tags for the default mode
[PATCH 6/8] perf stat,metrics: New metricgroup output for the default mode
[PATCH 7/8] pert tests: Support metricgroup perf stat JSON output
[PATCH 8/8] perf test: Add test case for the standard perf stat output