1. Patchew
  2. linux
  3. View series

[PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Sui Jingfeng posted 1 patch 2 years, 8 months ago 
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Sui Jingfeng 2 years, 8 months ago 
Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig

make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-

  SYNC    include/config/auto.conf.cmd
  Checking missing-syscalls for N32
  CALL    scripts/checksyscalls.sh
  Checking missing-syscalls for O32
  CALL    scripts/checksyscalls.sh
  CALL    scripts/checksyscalls.sh
  MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2

V2: Order alphabetically

Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 drivers/gpu/drm/ingenic/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index a53f475d33df..b440e0cdc057 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -9,6 +9,8 @@ config DRM_INGENIC
 	select DRM_PANEL_BRIDGE
 	select DRM_KMS_HELPER
 	select DRM_GEM_DMA_HELPER
+	select REGMAP
+	select REGMAP_MMIO
 	select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
 	help
 	  Choose this option for DRM support for the Ingenic SoCs.
-- 
2.25.1
Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Paul Cercueil 2 years, 7 months ago 
Hi,

Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
> 
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> 
>   SYNC    include/config/auto.conf.cmd
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
> 
> V2: Order alphabetically
> 
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>

The patch looks good to me. But I need an ACK from someone else to
apply to drm-misc-next.

Cheers,
-Paul

> ---
>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
>         select DRM_GEM_DMA_HELPER
> +       select REGMAP
> +       select REGMAP_MMIO
>         select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
>         help
>           Choose this option for DRM support for the Ingenic SoCs.
Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Sam Ravnborg 2 years, 7 months ago 
Hi Paul,
On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> Hi,
> 
> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> > Otherwise its failed to pass basic compile test on platform without
> > REGMAP_MMIO selected by defconfig
> > 
> > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> > 
> >   SYNC    include/config/auto.conf.cmd
> >   Checking missing-syscalls for N32
> >   CALL    scripts/checksyscalls.sh
> >   Checking missing-syscalls for O32
> >   CALL    scripts/checksyscalls.sh
> >   CALL    scripts/checksyscalls.sh
> >   MODPOST Module.symvers
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > make: *** [Makefile:1978: modpost] Error 2
> > 
> > V2: Order alphabetically
> > 
> > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> 
> The patch looks good to me. But I need an ACK from someone else to
> apply to drm-misc-next.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Paul Cercueil 2 years, 7 months ago 
Hi,

Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit :
> Hi Paul,
> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> > Hi,
> > 
> > Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> > > Otherwise its failed to pass basic compile test on platform
> > > without
> > > REGMAP_MMIO selected by defconfig
> > > 
> > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> > > 
> > >   SYNC    include/config/auto.conf.cmd
> > >   Checking missing-syscalls for N32
> > >   CALL    scripts/checksyscalls.sh
> > >   Checking missing-syscalls for O32
> > >   CALL    scripts/checksyscalls.sh
> > >   CALL    scripts/checksyscalls.sh
> > >   MODPOST Module.symvers
> > > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
> > > 1
> > > make: *** [Makefile:1978: modpost] Error 2
> > > 
> > > V2: Order alphabetically
> > > 
> > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> > 
> > The patch looks good to me. But I need an ACK from someone else to
> > apply to drm-misc-next.
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Thanks Sam!

Applied to drm-misc-next.

Cheers,
-Paul
Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Sui Jingfeng 2 years, 7 months ago 
Hi,

On 2023/6/18 04:41, Paul Cercueil wrote:
> Hi,
>
> Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit :
>> Hi Paul,
>> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
>>> Hi,
>>>
>>> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
>>>> Otherwise its failed to pass basic compile test on platform
>>>> without
>>>> REGMAP_MMIO selected by defconfig
>>>>
>>>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>>>
>>>>    SYNC    include/config/auto.conf.cmd
>>>>    Checking missing-syscalls for N32
>>>>    CALL    scripts/checksyscalls.sh
>>>>    Checking missing-syscalls for O32
>>>>    CALL    scripts/checksyscalls.sh
>>>>    CALL    scripts/checksyscalls.sh
>>>>    MODPOST Module.symvers
>>>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>>>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
>>>> 1
>>>> make: *** [Makefile:1978: modpost] Error 2
>>>>
>>>> V2: Order alphabetically
>>>>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> The patch looks good to me. But I need an ACK from someone else to
>>> apply to drm-misc-next.
>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Thanks Sam!
Sam and Paul, thanks a lot, :-)
> Applied to drm-misc-next.
>
> Cheers,
> -Paul

-- 
Jingfeng
Re: [v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Posted by Sui Jingfeng 2 years, 8 months ago 
Hi,


Humble ping ?


On 2023/6/7 19:06, Sui Jingfeng wrote:
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
>    SYNC    include/config/auto.conf.cmd
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> V2: Order alphabetically
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
>   drivers/gpu/drm/ingenic/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
>   	select DRM_PANEL_BRIDGE
>   	select DRM_KMS_HELPER
>   	select DRM_GEM_DMA_HELPER
> +	select REGMAP
> +	select REGMAP_MMIO
>   	select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
>   	help
>   	  Choose this option for DRM support for the Ingenic SoCs.

-- 
Jingfeng

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.