docs: KVM: Fix register ID of SPSR_FIQ

[PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

Posted by Takahiro Itazuri 2 years, 8 months ago

Fixes the register ID of SPSR_FIQ.

SPSR_FIQ is a 64-bit register and the 64-bit register size mask is
0x0030000000000000ULL.

Fixes: fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")
Signed-off-by: Takahiro Itazuri <itazur@amazon.com>

---
Changes from v1
- Add a description about the 64-bit register size mask in the commit
  message.
- Link: https://lore.kernel.org/all/20230410121927.26953-1-itazur@amazon.com/

---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
index a5c803f39832..65dad2581751 100644
--- a/Documentation/virt/kvm/api.rst
+++ b/Documentation/virt/kvm/api.rst
@@ -2535,7 +2535,7 @@ Specifically:
   0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
   0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
   0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
-  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
+  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
   0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
   0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
   ...
-- 
2.38.0

Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

Posted by Oliver Upton 1 year, 6 months ago

On Tue, 6 Jun 2023 16:46:28 +0100, Takahiro Itazuri wrote:
> Fixes the register ID of SPSR_FIQ.
> 
> SPSR_FIQ is a 64-bit register and the 64-bit register size mask is
> 0x0030000000000000ULL.
> 
> 

Applied to kvmarm/fixes, thanks!

[1/1] docs: KVM: Fix register ID of SPSR_FIQ
      https://git.kernel.org/kvmarm/kvmarm/c/7fef1eb0b013

--
Best,
Oliver

Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

Posted by Zenghui Yu 1 year, 6 months ago

+Cc kvmarm people and the list ...

On 2023/6/6 23:46, Takahiro Itazuri wrote:
> Fixes the register ID of SPSR_FIQ.
> 
> SPSR_FIQ is a 64-bit register and the 64-bit register size mask is
> 0x0030000000000000ULL.
> 
> Fixes: fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")
> Signed-off-by: Takahiro Itazuri <itazur@amazon.com>

... since you're fixing the encoding of an *arm64* core register and the
mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess
this is the main reason why this patch has been blocked on the list for
over a year, as pointed out recently by Alexander [*].

> 
> ---
> Changes from v1
> - Add a description about the 64-bit register size mask in the commit
>   message.
> - Link: https://lore.kernel.org/all/20230410121927.26953-1-itazur@amazon.com/
> 
> ---
>  Documentation/virt/kvm/api.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> index a5c803f39832..65dad2581751 100644
> --- a/Documentation/virt/kvm/api.rst
> +++ b/Documentation/virt/kvm/api.rst
> @@ -2535,7 +2535,7 @@ Specifically:
>    0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
>    0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
>    0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
> -  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
> +  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
>    0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
>    0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
>    ...

The change itself looks reasonable.

Thanks,
Zenghui

[*] https://lore.kernel.org/all/20240802132036.914457-1-glider@google.com

Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

Posted by Marc Zyngier 1 year, 6 months ago

On Sun, 04 Aug 2024 09:17:47 +0100,
Zenghui Yu <zenghui.yu@linux.dev> wrote:
> 
> +Cc kvmarm people and the list ...

Thanks Zenghui.

> 
> On 2023/6/6 23:46, Takahiro Itazuri wrote:
> > Fixes the register ID of SPSR_FIQ.
> > 
> > SPSR_FIQ is a 64-bit register and the 64-bit register size mask is
> > 0x0030000000000000ULL.
> > 
> > Fixes: fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")
> > Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
> 
> ... since you're fixing the encoding of an *arm64* core register and the
> mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess
> this is the main reason why this patch has been blocked on the list for
> over a year, as pointed out recently by Alexander [*].

That, and the fact that this is send to an email address I haven't
been reachable on for about 5 years...

> 
> > 
> > ---
> > Changes from v1
> > - Add a description about the 64-bit register size mask in the commit
> >   message.
> > - Link: https://lore.kernel.org/all/20230410121927.26953-1-itazur@amazon.com/
> > 
> > ---
> >  Documentation/virt/kvm/api.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index a5c803f39832..65dad2581751 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -2535,7 +2535,7 @@ Specifically:
> >    0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
> >    0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
> >    0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
> > -  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
> > +  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
> >    0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
> >    0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
> >    ...
> 
> The change itself looks reasonable.
> 
> Thanks,
> Zenghui
> 
> [*] https://lore.kernel.org/all/20240802132036.914457-1-glider@google.com

In case Oliver picks this up for 6.11:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

Posted by Alexander Potapenko 1 year, 6 months ago

Hi folks,

I also came across this inconsistency in the docs. What happened to the patch in question?