Add initial support for RDP446 of IPQ5332 family

[PATCH 1/2] dt-bindings: arm: qcom: document MI04.1 board based on IPQ5332 family

Posted by Hariharan K 2 years, 8 months ago

Document the MI04.1 (Reference Design Platform 446) board based on IPQ5332
family of SoCs.

Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8302d1ee280d..165a815337f7 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -93,6 +93,7 @@ description: |
         ap-mi01.2
         ap-mi01.3
         ap-mi01.6
+        ap-mi04.1
         cdp
         cp01-c1
         dragonboard
@@ -340,6 +341,7 @@ properties:
               - qcom,ipq5332-ap-mi01.2
               - qcom,ipq5332-ap-mi01.3
               - qcom,ipq5332-ap-mi01.6
+              - qcom,ipq5332-ap-mi04.1
           - const: qcom,ipq5332
 
       - items:
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: arm: qcom: document MI04.1 board based on IPQ5332 family

Posted by Krzysztof Kozlowski 2 years, 8 months ago

On 06/06/2023 11:57, Hariharan K wrote:
> Document the MI04.1 (Reference Design Platform 446) board based on IPQ5332
> family of SoCs.
> 
> Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 8302d1ee280d..165a815337f7 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -93,6 +93,7 @@ description: |
>          ap-mi01.2
>          ap-mi01.3
>          ap-mi01.6
> +        ap-mi04.1

I think we need to stop adding them here... This was supposed to be
limited list for Qualcomm bootloader. Are you sure Qualcomm bootloader
requires such names with versions?

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: document MI04.1 board based on IPQ5332 family

Posted by Bjorn Andersson 2 years, 8 months ago

On Tue, Jun 06, 2023 at 01:28:27PM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2023 11:57, Hariharan K wrote:
> > Document the MI04.1 (Reference Design Platform 446) board based on IPQ5332
> > family of SoCs.
> > 
> > Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 8302d1ee280d..165a815337f7 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -93,6 +93,7 @@ description: |
> >          ap-mi01.2
> >          ap-mi01.3
> >          ap-mi01.6
> > +        ap-mi04.1
> 
> I think we need to stop adding them here... This was supposed to be
> limited list for Qualcomm bootloader. Are you sure Qualcomm bootloader
> requires such names with versions?
> 

Hariharan, can you please elaborate on what these numbers mean? Is this
just a version of ap-mi04? Or do we have 5 different reference boards on
IPQ5332, just with "cryptic" names?

Regards,
Bjorn

Re: [PATCH 1/2] dt-bindings: arm: qcom: document MI04.1 board based on IPQ5332 family

Posted by Hariharan K 2 years, 8 months ago


On 6/14/2023 4:34 AM, Bjorn Andersson wrote:
> On Tue, Jun 06, 2023 at 01:28:27PM +0200, Krzysztof Kozlowski wrote:
>> On 06/06/2023 11:57, Hariharan K wrote:
>>> Document the MI04.1 (Reference Design Platform 446) board based on IPQ5332
>>> family of SoCs.
>>>
>>> Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index 8302d1ee280d..165a815337f7 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -93,6 +93,7 @@ description: |
>>>           ap-mi01.2
>>>           ap-mi01.3
>>>           ap-mi01.6
>>> +        ap-mi04.1
>>
>> I think we need to stop adding them here... This was supposed to be
>> limited list for Qualcomm bootloader. Are you sure Qualcomm bootloader
>> requires such names with versions?
>>
> 
> Hariharan, can you please elaborate on what these numbers mean? Is this
> just a version of ap-mi04? Or do we have 5 different reference boards on
> IPQ5332, just with "cryptic" names?
> 
> Regards,
> Bjorn

Yes. These are different reference board designs based on IPQ5332.

Thanks,
Hariharan K