net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

[PATCH] net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

Posted by Min-Hua Chen 10 months, 3 weeks ago

This patch fixes the following sparse warning:

net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
 net/sched/sch_api.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 014209b1dd58..9ea51812b9cf 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
 	.exit = psched_net_exit,
 };
 
+#if IS_ENABLED(CONFIG_RETPOLINE)
 DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
+#endif
 
 static int __init pktsched_init(void)
 {
-- 
2.34.1

Re: [PATCH] net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

Posted by patchwork-bot+netdevbpf@kernel.org 10 months, 2 weeks ago

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat,  3 Jun 2023 07:52:09 +0800 you wrote:
> This patch fixes the following sparse warning:
> 
> net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> 
> [...]

Here is the summary with links:
  - net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE
    https://git.kernel.org/netdev/net/c/8cde87b007da

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

Posted by Pedro Tammela 10 months, 3 weeks ago

On 02/06/2023 20:52, Min-Hua Chen wrote:
> This patch fixes the following sparse warning:
> 
> net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>

LGTM,

Acked-by: Pedro Tammela <pctammela@mojatatu.com>

> ---
>   net/sched/sch_api.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index 014209b1dd58..9ea51812b9cf 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
>   	.exit = psched_net_exit,
>   };
>   
> +#if IS_ENABLED(CONFIG_RETPOLINE)
>   DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
> +#endif
>   
>   static int __init pktsched_init(void)
>   {