[v1] Move KSZ9477 errata handling to PHY driver

[PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

Posted by Robert Hancock 10 months, 2 weeks ago

Patches to move handling for KSZ9477 PHY errata register fixes from
the DSA switch driver into the corresponding PHY driver, for more
proper layering and ordering.

Robert Hancock (2):
  net: phy: micrel: Move KSZ9477 errata fixes to PHY driver
  net: dsa: microchip: remove KSZ9477 PHY errata handling

 drivers/net/dsa/microchip/ksz9477.c    | 74 ++-----------------------
 drivers/net/dsa/microchip/ksz_common.c |  4 --
 drivers/net/dsa/microchip/ksz_common.h |  1 -
 drivers/net/phy/micrel.c               | 75 +++++++++++++++++++++++++-
 4 files changed, 78 insertions(+), 76 deletions(-)

-- 
2.40.1

Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

Posted by Simon Horman 10 months, 2 weeks ago

On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> Patches to move handling for KSZ9477 PHY errata register fixes from
> the DSA switch driver into the corresponding PHY driver, for more
> proper layering and ordering.
> 
> Robert Hancock (2):
>   net: phy: micrel: Move KSZ9477 errata fixes to PHY driver
>   net: dsa: microchip: remove KSZ9477 PHY errata handling

Hi Robert,

this series does not seem to apply to net-next.
Please rebase on to of net-next and repost as v2.
And please include the Reviewed-by tags from Andrew Lunn in v2,
assuming there are no other changes.

-- 
pw-bot: rc

Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

Posted by Andrew Lunn 10 months, 2 weeks ago

On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> Patches to move handling for KSZ9477 PHY errata register fixes from
> the DSA switch driver into the corresponding PHY driver, for more
> proper layering and ordering.

Hi Robert

Is it an issue when it is performed twice, both in the PHY and the DSA
driver? This could happen if somebody was doing a git bisect and
landed in the middle of these two.

       Andrew

Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

Posted by Robert Hancock 10 months, 2 weeks ago

On Sat, 2023-06-03 at 02:04 +0200, Andrew Lunn wrote:
> On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> > Patches to move handling for KSZ9477 PHY errata register fixes from
> > the DSA switch driver into the corresponding PHY driver, for more
> > proper layering and ordering.
> 
> 
> Hi Robert
> 
> Is it an issue when it is performed twice, both in the PHY and the
> DSA
> driver? This could happen if somebody was doing a git bisect and
> landed in the middle of these two.
> 
>        Andrew

I don't think you'd really end up in a worse position than without
either patch, it would just be doing some redundant register writes.

-- 
Robert Hancock <robert.hancock@calian.com>