[PATCH] bpf: cleanup unused function declaration

GONG, Ruiqi posted 1 patch 2 years, 8 months ago
There is a newer version of this series
include/linux/filter.h | 1 -
1 file changed, 1 deletion(-)
[PATCH] bpf: cleanup unused function declaration
Posted by GONG, Ruiqi 2 years, 8 months ago
All usage and the definition of `bpf_prog_free_linfo()` has been removed
in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
jited_linfo"). Clean up its declaration in the header file.

Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
---
 include/linux/filter.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/filter.h b/include/linux/filter.h
index bbce89937fde..f69114083ec7 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
 
 bool bpf_opcode_in_insntable(u8 code);
 
-void bpf_prog_free_linfo(struct bpf_prog *prog);
 void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
 			       const u32 *insn_to_jit_off);
 int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
-- 
2.25.1
Re: [PATCH] bpf: cleanup unused function declaration
Posted by Stanislav Fomichev 2 years, 8 months ago
On 06/02, GONG, Ruiqi wrote:
> All usage and the definition of `bpf_prog_free_linfo()` has been removed
> in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> jited_linfo"). Clean up its declaration in the header file.
> 
> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>

Acked-by: Stanislav Fomichev <sdf@google.com>

> ---
>  include/linux/filter.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index bbce89937fde..f69114083ec7 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
>  
>  bool bpf_opcode_in_insntable(u8 code);
>  
> -void bpf_prog_free_linfo(struct bpf_prog *prog);
>  void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
>  			       const u32 *insn_to_jit_off);
>  int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> -- 
> 2.25.1
>
Re: [PATCH] bpf: cleanup unused function declaration
Posted by Andrii Nakryiko 2 years, 8 months ago
On Fri, Jun 2, 2023 at 9:12 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> On 06/02, GONG, Ruiqi wrote:
> > All usage and the definition of `bpf_prog_free_linfo()` has been removed
> > in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> > jited_linfo"). Clean up its declaration in the header file.
> >
> > Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
>

I'm actually having trouble applying this locally. Can you please
rebase against bpf-next/master and resend it? Also, please check
Signed-off-by's "<first> <last> <email>" order and spelling. Should it
be "Ruiqi Gong <...>"?


> Acked-by: Stanislav Fomichev <sdf@google.com>
>
> > ---
> >  include/linux/filter.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/filter.h b/include/linux/filter.h
> > index bbce89937fde..f69114083ec7 100644
> > --- a/include/linux/filter.h
> > +++ b/include/linux/filter.h
> > @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
> >
> >  bool bpf_opcode_in_insntable(u8 code);
> >
> > -void bpf_prog_free_linfo(struct bpf_prog *prog);
> >  void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
> >                              const u32 *insn_to_jit_off);
> >  int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> > --
> > 2.25.1
> >