[v3] dmaengine: edma: add freescale edma v3 support

[PATCH v3 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string

Posted by Frank Li 2 years, 8 months ago

Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in
i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/dma/fsl,edma.yaml     | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
index 5fd8fc604261..ec0fe8735ec7 100644
--- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
@@ -21,6 +21,10 @@ properties:
       - enum:
           - fsl,vf610-edma
           - fsl,imx7ulp-edma
+          - fsl,imx8qm-edma
+          - fsl,imx8qm-adma
+          - fsl,imx93-edma3
+          - fsl,imx93-edma4
       - items:
           - const: fsl,ls1028a-edma
           - const: fsl,vf610-edma
@@ -49,6 +53,10 @@ properties:
   clock-names:
     maxItems: 2
 
+  fsl,channel-mask:
+    $ref: /schemas/types.yaml#/definitions/uint64
+    description: A bitmask lets you skip certain channel.
+
   big-endian:
     description: |
       If present registers and hardware scatter/gather descriptors of the
@@ -101,6 +109,26 @@ allOf:
         reg:
           maxItems: 2
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            anyOf:
+              - const: fsl,imx8qm-edma
+              - const: fsl,imx8qm-adma
+              - const: fsl,imx93-edma3
+              - const: fsl,imx93-edma4
+    then:
+      properties:
+        reg:
+          maxItems: 1
+        interrupts:
+          minItems: 1
+          maxItems: 64
+        interrupt-names:
+          minItems: 1
+          maxItems: 64
+
 unevaluatedProperties: false
 
 examples:
-- 
2.34.1

Re: [PATCH v3 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string

Posted by Krzysztof Kozlowski 2 years, 8 months ago

On 01/06/2023 16:41, Frank Li wrote:
> Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in
> i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/dma/fsl,edma.yaml     | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 5fd8fc604261..ec0fe8735ec7 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,6 +21,10 @@ properties:
>        - enum:
>            - fsl,vf610-edma
>            - fsl,imx7ulp-edma
> +          - fsl,imx8qm-edma
> +          - fsl,imx8qm-adma
> +          - fsl,imx93-edma3
> +          - fsl,imx93-edma4
>        - items:
>            - const: fsl,ls1028a-edma
>            - const: fsl,vf610-edma
> @@ -49,6 +53,10 @@ properties:
>    clock-names:
>      maxItems: 2
>  
> +  fsl,channel-mask:
> +    $ref: /schemas/types.yaml#/definitions/uint64
> +    description: A bitmask lets you skip certain channel.

There is already a property for this - included in your binding:
dma-channel-mask. Use this one.

Best regards,
Krzysztof