1. Patchew
  2. linux
  3. [PATCH v3 0/8] Add support for MT6331 and MT6332 LEDs
  4. View patch

[PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output

AngeloGioacchino Del Regno posted 8 patches 1 year, 3 months ago
[PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by AngeloGioacchino Del Regno 1 year, 3 months ago 
Some PMICs have a separated WLED string output: add a property
`mediatek,is-wled` to indicate which LED string is a WLED.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
index 052dccb8f2ce..904b2222a5fe 100644
--- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
+++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
@@ -30,6 +30,7 @@ Optional properties for the LED child node:
 - label : See Documentation/devicetree/bindings/leds/common.txt
 - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
 - default-state: See Documentation/devicetree/bindings/leds/common.txt
+- mediatek,is-wled: LED string is connected to WLED output
 
 Example:
 
-- 
2.40.1
Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by Krzysztof Kozlowski 1 year, 3 months ago 
On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
> Some PMICs have a separated WLED string output: add a property
> `mediatek,is-wled` to indicate which LED string is a WLED.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> index 052dccb8f2ce..904b2222a5fe 100644
> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>  - label : See Documentation/devicetree/bindings/leds/common.txt
>  - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>  - default-state: See Documentation/devicetree/bindings/leds/common.txt
> +- mediatek,is-wled: LED string is connected to WLED output

Why would it matter to what the output is connected to?

Best regards,
Krzysztof
Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by AngeloGioacchino Del Regno 1 year, 3 months ago 
Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
>> Some PMICs have a separated WLED string output: add a property
>> `mediatek,is-wled` to indicate which LED string is a WLED.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>> index 052dccb8f2ce..904b2222a5fe 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>>   - label : See Documentation/devicetree/bindings/leds/common.txt
>>   - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>>   - default-state: See Documentation/devicetree/bindings/leds/common.txt
>> +- mediatek,is-wled: LED string is connected to WLED output
> 
> Why would it matter to what the output is connected to?

When this property is present, the MT6323 LEDs are managed through different
hardware registers which are specific to WLEDs: if we have no indication of
whether this is a WLED or a LED, we would program the wrong registers.

P.S.: Sorry for the very late reply

> 
> Best regards,
> Krzysztof
> 
>
Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by Krzysztof Kozlowski 1 year, 3 months ago 
On 09/06/2023 09:51, AngeloGioacchino Del Regno wrote:
> Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
>> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
>>> Some PMICs have a separated WLED string output: add a property
>>> `mediatek,is-wled` to indicate which LED string is a WLED.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>>   Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> index 052dccb8f2ce..904b2222a5fe 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>>>   - label : See Documentation/devicetree/bindings/leds/common.txt
>>>   - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>>>   - default-state: See Documentation/devicetree/bindings/leds/common.txt
>>> +- mediatek,is-wled: LED string is connected to WLED output
>>
>> Why would it matter to what the output is connected to?
> 
> When this property is present, the MT6323 LEDs are managed through different
> hardware registers which are specific to WLEDs: if we have no indication of
> whether this is a WLED or a LED, we would program the wrong registers.
> 

OK, so it is rather the choice of output in the device? What is "LED
string" in this context?


Best regards,
Krzysztof
Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by AngeloGioacchino Del Regno 1 year, 3 months ago 
Il 13/06/23 08:59, Krzysztof Kozlowski ha scritto:
> On 09/06/2023 09:51, AngeloGioacchino Del Regno wrote:
>> Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
>>> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
>>>> Some PMICs have a separated WLED string output: add a property
>>>> `mediatek,is-wled` to indicate which LED string is a WLED.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>>> index 052dccb8f2ce..904b2222a5fe 100644
>>>> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>>> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>>> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>>>>    - label : See Documentation/devicetree/bindings/leds/common.txt
>>>>    - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>>>>    - default-state: See Documentation/devicetree/bindings/leds/common.txt
>>>> +- mediatek,is-wled: LED string is connected to WLED output
>>>
>>> Why would it matter to what the output is connected to?
>>
>> When this property is present, the MT6323 LEDs are managed through different
>> hardware registers which are specific to WLEDs: if we have no indication of
>> whether this is a WLED or a LED, we would program the wrong registers.
>>
> 
> OK, so it is rather the choice of output in the device? What is "LED
> string" in this context?
> 

"LED string" is a term that is commonly used to refer to an array of LEDs.
Usually, in the context of displays (so, WLED!), it refers to the LEDs array
that forms the backlight.

And yes, it's choice of output in the HW.

Cheers,
Angelo
Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Posted by Lee Jones 1 year, 3 months ago 
On Fri, 02 Jun 2023, Krzysztof Kozlowski wrote:

> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
> > Some PMICs have a separated WLED string output: add a property
> > `mediatek,is-wled` to indicate which LED string is a WLED.
> > 
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > index 052dccb8f2ce..904b2222a5fe 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > @@ -30,6 +30,7 @@ Optional properties for the LED child node:
> >  - label : See Documentation/devicetree/bindings/leds/common.txt
> >  - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
> >  - default-state: See Documentation/devicetree/bindings/leds/common.txt
> > +- mediatek,is-wled: LED string is connected to WLED output
> 
> Why would it matter to what the output is connected to?

Skipping this one.  Please resolve and resend.

-- 
Lee Jones [李琼斯]

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.