[v1] gpio: ath79: Add missing check for platform_get_irq

[PATCH] gpio: ath79: Add missing check for platform_get_irq

Jiasheng Jiang posted 1 patch 2 years, 8 months ago

Diff against v2 v3 v3
Download mbox

There is a newer version of this series

drivers/gpio/gpio-ath79.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] gpio: ath79: Add missing check for platform_get_irq

Posted by Jiasheng Jiang 2 years, 8 months ago

Add the missing check for platform_get_irq and return error
if it fails.

Fixes: 2b8f89e19b6d ("gpio: ath79: Add support for the interrupt controller")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/gpio/gpio-ath79.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index aa0a954b8392..4b67428a8c17 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -286,6 +286,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
 		if (!girq->parents)
 			return -ENOMEM;
 		girq->parents[0] = platform_get_irq(pdev, 0);
+		if (girq->parents[0] < 0)
+			return -ENODEV;
 		girq->default_type = IRQ_TYPE_NONE;
 		girq->handler = handle_simple_irq;
 	}
-- 
2.25.1

Re: [PATCH] gpio: ath79: Add missing check for platform_get_irq

Posted by andy.shevchenko@gmail.com 2 years, 8 months ago

Thu, Jun 01, 2023 at 04:51:32PM +0800, Jiasheng Jiang kirjoitti:
> Add the missing check for platform_get_irq and return error
> if it fails.

>  		girq->parents[0] = platform_get_irq(pdev, 0);
> +		if (girq->parents[0] < 0)
> +			return -ENODEV;

Can you elaborate why error code has to be shadowed (overriden)?

-- 
With Best Regards,
Andy Shevchenko