[v1] mfd: intel-lpss: Add missing check for platform_get_resource

[PATCH] mfd: intel-lpss: Add missing check for platform_get_resource

Posted by Jiasheng Jiang 2 years, 8 months ago

Add the missing check for platform_get_resource and return error
if it fails.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/mfd/intel-lpss-acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
index a143c8dca2d9..1a6ebd3d9795 100644
--- a/drivers/mfd/intel-lpss-acpi.c
+++ b/drivers/mfd/intel-lpss-acpi.c
@@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!info->mem)
+		return -ENOMEM;
+
 	info->irq = platform_get_irq(pdev, 0);
 
 	ret = intel_lpss_probe(&pdev->dev, info);
-- 
2.25.1

Re: [PATCH] mfd: intel-lpss: Add missing check for platform_get_resource

Posted by Lee Jones 2 years, 8 months ago

On Wed, 31 May 2023, Jiasheng Jiang wrote:

> Add the missing check for platform_get_resource and return error
> if it fails.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/mfd/intel-lpss-acpi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
> index a143c8dca2d9..1a6ebd3d9795 100644
> --- a/drivers/mfd/intel-lpss-acpi.c
> +++ b/drivers/mfd/intel-lpss-acpi.c
> @@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!info->mem)
> +		return -ENOMEM;

This does not mean we're out of memory.

Please use either -EINVAL or -ENODEV.

> +
>  	info->irq = platform_get_irq(pdev, 0);
>  
>  	ret = intel_lpss_probe(&pdev->dev, info);
> -- 
> 2.25.1
> 

-- 
Lee Jones [李琼斯]