leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static

[PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static

Posted by Tom Rix 2 years, 8 months ago

smatch reports
drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
  'cht_wc_leds_brightness_get' was not declared. Should it be static?

This function is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/leds/leds-cht-wcove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee98910..0a5c30e5ed5d 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
 	return ret;
 }
 
-enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
+static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
 {
 	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
 	unsigned int val;
-- 
2.27.0

Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static

Posted by Lee Jones 2 years, 8 months ago

On Tue, 30 May 2023, Tom Rix wrote:

> smatch reports
> drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
>   'cht_wc_leds_brightness_get' was not declared. Should it be static?
> 
> This function is only used in its defining file, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/leds/leds-cht-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, you were pipped to the post:

https://lore.kernel.org/r/20230525183317.129232-1-hdegoede@redhat.com

-- 
Lee Jones [李琼斯]