[PATCH] dirvers/gpio: remove redundant reset gpio suffix

Lizhe posted 1 patch 2 years, 8 months ago
sound/soc/codecs/cs35l34.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dirvers/gpio: remove redundant reset gpio suffix
Posted by Lizhe 2 years, 8 months ago
no need to add the suffix "gpio" or "gpios" after "reset", as they will
be automatically added, see of_find_gpio().

Signed-off-by: Lizhe <sensor1010@163.com>
---
 sound/soc/codecs/cs35l34.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c
index b3f98023e6a7..cbf0f2f4f9df 100644
--- a/sound/soc/codecs/cs35l34.c
+++ b/sound/soc/codecs/cs35l34.c
@@ -1061,7 +1061,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client)
 		dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret);
 
 	cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev,
-				"reset-gpios", GPIOD_OUT_LOW);
+				"reset", GPIOD_OUT_LOW);
 	if (IS_ERR(cs35l34->reset_gpio)) {
 		ret = PTR_ERR(cs35l34->reset_gpio);
 		goto err_regulator;
-- 
2.34.1
Re: [PATCH] dirvers/gpio: remove redundant reset gpio suffix
Posted by Charles Keepax 2 years, 8 months ago
On Wed, May 31, 2023 at 12:32:10AM +0800, Lizhe wrote:
> no need to add the suffix "gpio" or "gpios" after "reset", as they will
> be automatically added, see of_find_gpio().
> 

Patch itself looks fine, but the subject line should really be
ASoC: cs35l34: ... rather than gpio.

Thanks,
Charles