[net-next PATCH v3 06/13] leds: trigger: netdev: add basic check for hw control support

Christian Marangi posted 13 patches 2 years, 8 months ago
There is a newer version of this series
[net-next PATCH v3 06/13] leds: trigger: netdev: add basic check for hw control support
Posted by Christian Marangi 2 years, 8 months ago
Add basic check for hw control support. Check if the required API are
defined and check if the defined trigger supported in hw control for the
LED driver match netdev.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/leds/trigger/ledtrig-netdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index e1f3cedd5d57..2101cbbda707 100644
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -92,8 +92,22 @@ static void set_baseline_state(struct led_netdev_data *trigger_data)
 	}
 }
 
+static bool supports_hw_control(struct led_classdev *led_cdev)
+{
+	if (!led_cdev->hw_control_get || !led_cdev->hw_control_set ||
+	    !led_cdev->hw_control_is_supported)
+		return false;
+
+	return !strcmp(led_cdev->hw_control_trigger, led_cdev->trigger->name);
+}
+
 static bool can_hw_control(struct led_netdev_data *trigger_data)
 {
+	struct led_classdev *led_cdev = trigger_data->led_cdev;
+
+	if (!supports_hw_control(led_cdev))
+		return false;
+
 	return false;
 }
 
-- 
2.39.2
Re: [net-next PATCH v3 06/13] leds: trigger: netdev: add basic check for hw control support
Posted by Andrew Lunn 2 years, 8 months ago
On Sat, May 27, 2023 at 01:28:47PM +0200, Christian Marangi wrote:
> Add basic check for hw control support. Check if the required API are
> defined and check if the defined trigger supported in hw control for the
> LED driver match netdev.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew