[v3] blk-wbt: minor fix and cleanup

[PATCH -next v3 0/5] blk-wbt: minor fix and cleanup

Posted by Yu Kuai 2 years, 8 months ago

From: Yu Kuai <yukuai3@huawei.com>

Changes in v3:
 - patch 1 from v2 is sent separately, and it's removd from this series.
 - add review tag for all the patches.

Changes in v2:
 - make the code more readable for patch 1
 - add a new attr_group that is only visible for rq based device
 - explain in detail for patch 4
 - add review tag for patch 2,3,5

Yu Kuai (5):
  blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
  blk-wbt: remove dead code to handle wbt enable/disable with io
    inflight
  blk-wbt: cleanup rwb_enabled() and wbt_disabled()
  blk-iocost: move wbt_enable/disable_default() out of spinlock
  blk-sysfs: add a new attr_group for blk_mq

 block/blk-iocost.c |   7 +-
 block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
 block/blk-wbt.c    |  21 +-----
 block/blk-wbt.h    |  19 -----
 4 files changed, 110 insertions(+), 118 deletions(-)

-- 
2.39.2

Re: [PATCH -next v3 0/5] blk-wbt: minor fix and cleanup

Posted by Yu Kuai 2 years, 8 months ago

Hi, Jens

Can you apply this patchset?

Thanks,
Kuai

在 2023/05/27 9:06, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v3:
>   - patch 1 from v2 is sent separately, and it's removd from this series.
>   - add review tag for all the patches.
> 
> Changes in v2:
>   - make the code more readable for patch 1
>   - add a new attr_group that is only visible for rq based device
>   - explain in detail for patch 4
>   - add review tag for patch 2,3,5
> 
> Yu Kuai (5):
>    blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>    blk-wbt: remove dead code to handle wbt enable/disable with io
>      inflight
>    blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>    blk-iocost: move wbt_enable/disable_default() out of spinlock
>    blk-sysfs: add a new attr_group for blk_mq
> 
>   block/blk-iocost.c |   7 +-
>   block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>   block/blk-wbt.c    |  21 +-----
>   block/blk-wbt.h    |  19 -----
>   4 files changed, 110 insertions(+), 118 deletions(-)
>

Re: [PATCH -next v3 0/5] blk-wbt: minor fix and cleanup

Posted by Yu Kuai 2 years, 7 months ago

Hi, Jens

在 2023/06/08 10:36, Yu Kuai 写道:
> Hi, Jens
> 
> Can you apply this patchset?

The only fix from this patchset is applied separately, so this patchset
is just simple cleanups now, can you please consider this for the next
merge window?

Thanks,
Kuai
> 
> Thanks,
> Kuai
> 
> 在 2023/05/27 9:06, Yu Kuai 写道:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Changes in v3:
>>   - patch 1 from v2 is sent separately, and it's removd from this series.
>>   - add review tag for all the patches.
>>
>> Changes in v2:
>>   - make the code more readable for patch 1
>>   - add a new attr_group that is only visible for rq based device
>>   - explain in detail for patch 4
>>   - add review tag for patch 2,3,5
>>
>> Yu Kuai (5):
>>    blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>>    blk-wbt: remove dead code to handle wbt enable/disable with io
>>      inflight
>>    blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>>    blk-iocost: move wbt_enable/disable_default() out of spinlock
>>    blk-sysfs: add a new attr_group for blk_mq
>>
>>   block/blk-iocost.c |   7 +-
>>   block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>>   block/blk-wbt.c    |  21 +-----
>>   block/blk-wbt.h    |  19 -----
>>   4 files changed, 110 insertions(+), 118 deletions(-)
>>
> 
> .
>

Re: [PATCH -next v3 0/5] blk-wbt: minor fix and cleanup

Posted by Jens Axboe 2 years, 7 months ago

On Sat, 27 May 2023 09:06:39 +0800, Yu Kuai wrote:
> Changes in v3:
>  - patch 1 from v2 is sent separately, and it's removd from this series.
>  - add review tag for all the patches.
> 
> Changes in v2:
>  - make the code more readable for patch 1
>  - add a new attr_group that is only visible for rq based device
>  - explain in detail for patch 4
>  - add review tag for patch 2,3,5
> 
> [...]

Applied, thanks!

[1/5] blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
      commit: 645a829e03384a235b3760959d4ebe420a0f2027
[2/5] blk-wbt: remove dead code to handle wbt enable/disable with io inflight
      commit: 71b8642e79f277459555629f2bea1a8d1fed307e
[3/5] blk-wbt: cleanup rwb_enabled() and wbt_disabled()
      commit: 06257fda83ebfd1c33fb992e41dba7be4e1184d4
[4/5] blk-iocost: move wbt_enable/disable_default() out of spinlock
      commit: eebc21d12f56c1e09a163abf91e351fa2a55a938
[5/5] blk-sysfs: add a new attr_group for blk_mq
      commit: 6d85ebf95c44e52337ca1d07f0db4b435d1e6762

Best regards,
-- 
Jens Axboe