[v2] Add QFPROM support for few IPQ SoCs

[PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

Posted by Kathiravan T 2 years, 8 months ago

IPQ6018 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Reorder the node based on node address

 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index f531797f2619..0f6d6c6daed2 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -302,6 +302,13 @@
 			status = "disabled";
 		};
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
+			reg = <0x0 0x000a4000 0x0 0x2000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		prng: qrng@e1000 {
 			compatible = "qcom,prng-ee";
 			reg = <0x0 0x000e3000 0x0 0x1000>;
-- 
2.17.1

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

Posted by Dmitry Baryshkov 2 years, 8 months ago

On Fri, 26 May 2023 at 15:54, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
>         - Reorder the node based on node address
>
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..0f6d6c6daed2 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -302,6 +302,13 @@
>                         status = "disabled";
>                 };
>
> +               qfprom: efuse@a4000 {
> +                       compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> +                       reg = <0x0 0x000a4000 0x0 0x2000>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +               };
> +
>                 prng: qrng@e1000 {
>                         compatible = "qcom,prng-ee";
>                         reg = <0x0 0x000e3000 0x0 0x1000>;

It looks like the prng node name is incorrect. It should be qrng@e3000
instead of qrng@e1000. Could you please send a followup to fix it?

For this patch:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> --
> 2.17.1
>


-- 
With best wishes
Dmitry

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

Posted by Konrad Dybcio 2 years, 8 months ago


On 26.05.2023 15:22, Dmitry Baryshkov wrote:
> On Fri, 26 May 2023 at 15:54, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>>
>> IPQ6018 has efuse region to determine the various HW quirks. Lets
>> add the initial support and the individual fuses will be added as they
>> are required.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>>         - Reorder the node based on node address
>>
>>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index f531797f2619..0f6d6c6daed2 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -302,6 +302,13 @@
>>                         status = "disabled";
>>                 };
>>
>> +               qfprom: efuse@a4000 {
>> +                       compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
>> +                       reg = <0x0 0x000a4000 0x0 0x2000>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <1>;
>> +               };
>> +
>>                 prng: qrng@e1000 {
>>                         compatible = "qcom,prng-ee";
>>                         reg = <0x0 0x000e3000 0x0 0x1000>;
> 
> It looks like the prng node name is incorrect. It should be qrng@e3000
> instead of qrng@e1000. Could you please send a followup to fix it?
In case that wasn't clear, since I think this series will go in as-is,
that fix would be sent separately, on top of this.

Konrad
> 
> For this patch:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
>> --
>> 2.17.1
>>
> 
>

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

Posted by Konrad Dybcio 2 years, 8 months ago


On 26.05.2023 14:53, Kathiravan T wrote:
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> Changes in V2:
> 	- Reorder the node based on node address
> 
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..0f6d6c6daed2 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -302,6 +302,13 @@
>  			status = "disabled";
>  		};
>  
> +		qfprom: efuse@a4000 {
> +			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> +			reg = <0x0 0x000a4000 0x0 0x2000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		prng: qrng@e1000 {
>  			compatible = "qcom,prng-ee";
>  			reg = <0x0 0x000e3000 0x0 0x1000>;