[PATCH 0/2] platform/surface: aggregator_tabletsw: Add support for book mode

Maximilian Luz posted 2 patches 2 years, 8 months ago
drivers/platform/surface/surface_aggregator_tabletsw.c | 10 ++++++++++
1 file changed, 10 insertions(+)
[PATCH 0/2] platform/surface: aggregator_tabletsw: Add support for book mode
Posted by Maximilian Luz 2 years, 8 months ago
Surface devices with a type-cover have an additional "book" mode. This
mode is activated when the device is oriented in portrait mode and the
type-cover is in an open position (including completely folded back;
unlike in landscape orientation there are no special modes for any of
the intermediate positions).

Currently, this mode is unsupported by the tablet switch driver, leading
to an error message (see individual commits for the exact messages).
Since the keyboard and touchpad input gets deactivated in this mode, map
it to tablet-mode.

I've split this change into two patches, one for each of the subsystems
(KIP and POS). This a) allows proper attribution via the "Fixes" tag and
b) with that should allow them to be backported fairly easily.

Maximilian Luz (2):
  platform/surface: aggregator_tabletsw: Add support for book mode in
    KIP subsystem
  platform/surface: aggregator_tabletsw: Add support for book mode in
    POS subsystem

 drivers/platform/surface/surface_aggregator_tabletsw.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.40.1
Re: [PATCH 0/2] platform/surface: aggregator_tabletsw: Add support for book mode
Posted by Hans de Goede 2 years, 8 months ago
Hi,

On 5/25/23 23:32, Maximilian Luz wrote:
> Surface devices with a type-cover have an additional "book" mode. This
> mode is activated when the device is oriented in portrait mode and the
> type-cover is in an open position (including completely folded back;
> unlike in landscape orientation there are no special modes for any of
> the intermediate positions).
> 
> Currently, this mode is unsupported by the tablet switch driver, leading
> to an error message (see individual commits for the exact messages).
> Since the keyboard and touchpad input gets deactivated in this mode, map
> it to tablet-mode.
> 
> I've split this change into two patches, one for each of the subsystems
> (KIP and POS). This a) allows proper attribution via the "Fixes" tag and
> b) with that should allow them to be backported fairly easily.

Thank you for your patch series, I've applied this series
to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

I will include this series in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans






> Maximilian Luz (2):
>   platform/surface: aggregator_tabletsw: Add support for book mode in
>     KIP subsystem
>   platform/surface: aggregator_tabletsw: Add support for book mode in
>     POS subsystem
> 
>  drivers/platform/surface/surface_aggregator_tabletsw.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>