[v2] adm1266.c: Fix error checking for debugfs_create_dir

[PATCH v2] adm1266.c: Fix error checking for debugfs_create_dir

Osama Muhammad posted 1 patch 2 years, 8 months ago

Diff against v1
Download mbox

drivers/hwmon/pmbus/adm1266.c | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH v2] adm1266.c: Fix error checking for debugfs_create_dir

Posted by Osama Muhammad 2 years, 8 months ago

This patch fixes the error checking in adm1266.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.

Signed-off-by: Osama Muhammad <osmtendev@gmail.com>

---

changes since v1:
	-Dropped the error checking for debugfs_create_dir
---
 drivers/hwmon/pmbus/adm1266.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
index d88b6115b42e..184d75269d2b 100644
--- a/drivers/hwmon/pmbus/adm1266.c
+++ b/drivers/hwmon/pmbus/adm1266.c
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
 		return;
 
 	data->debugfs_dir = debugfs_create_dir(data->client->name, root);
-	if (IS_ERR(data->debugfs_dir))
-		return;
 
 	debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
 				    adm1266_state_read);
-- 
2.34.1