The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 kernel/sched/psi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77397f6..2ccb0b2ebd78 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
 static int psi_bug __read_mostly;
 
 DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
 
 #ifdef CONFIG_PSI_DEFAULT_DISABLED
 static bool psi_enable;
-- 
2.27.0

On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

This was previously submitted by Tom:
https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/

Peter, could you please pick this up?

Thanks!

On Thu, May 25, 2023 at 01:49:37PM -0400, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> > The static key psi_cgroups_enabled is only used inside file psi.c.
> > Make it static.
> > 
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/
> 
> Peter, could you please pick this up?

Found it, will queue after -rc1.

On 2023/5/26 1:49, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
>> The static key psi_cgroups_enabled is only used inside file psi.c.
>> Make it static.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/
> 
> Peter, could you please pick this up?
> 

friendly ping.. :)

> Thanks!
> .
>

On Wed, May 24, 2023 at 7:43 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 81fca77397f6..2ccb0b2ebd78 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -140,7 +140,7 @@
>  static int psi_bug __read_mostly;
>
>  DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
>  #ifdef CONFIG_PSI_DEFAULT_DISABLED
>  static bool psi_enable;
> --
> 2.27.0
>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Gitweb:        https://git.kernel.org/tip/35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Author:        Miaohe Lin <linmiaohe@huawei.com>
AuthorDate:    Thu, 25 May 2023 18:34:28 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 13 Jul 2023 15:21:50 +02:00

sched/psi: make psi_cgroups_enabled static

The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Link: https://lore.kernel.org/r/20230525103428.49712-1-linmiaohe@huawei.com
---
 kernel/sched/psi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77..2ccb0b2 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
 static int psi_bug __read_mostly;
 
 DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
 
 #ifdef CONFIG_PSI_DEFAULT_DISABLED
 static bool psi_enable;