From: Florian Sylvestre <fsylvestre@baylibre.com>
This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in
some Mediatek soc, such as the mt8365
Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
Signed-off-by: Julien Stephan <jstephan@baylibre.com>
---
.../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++++++++++++++++++
MAINTAINERS | 6 ++
2 files changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
new file mode 100644
index 000000000000..a1bd96a98051
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2023 MediaTek, BayLibre
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek Sensor Interface MIPI CSI CD-PHY
+
+maintainers:
+ - Julien Stephan <jstephan@baylibre.com>
+ - Andy Hsieh <andy.hsieh@mediatek.com>
+
+description:
+ The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2
+ receivers. The number of PHYs depends on the SoC model.
+ Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only
+ capable.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8365-csi-rx
+
+ reg:
+ maxItems: 1
+
+ '#phy-cells':
+ const: 0
+
+ mediatek,phy-type:
+ description:
+ Specify the phy type. Supported phy are D-PHY only or CD-PHY capable phys.
+ See include/dt-bindings/phy/phy.h for constants.
+ enum: [10, 13]
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+ - compatible
+ - reg
+ - mediatek,phy-type
+ - '#phy-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/phy/phy.h>
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ csi0_rx: phy@11c10000 {
+ compatible = "mediatek,mt8365-csi-rx";
+ reg = <0 0x11c10000 0 0x2000>;
+ mediatek,phy-type = <PHY_TYPE_CDPHY>;
+ #phy-cells = <0>;
+ };
+
+ csi1_rx: phy@11c12000 {
+ compatible = "mediatek,mt8365-csi-rx";
+ reg = <0 0x11c12000 0 0x2000>;
+ mediatek,phy-type = <PHY_TYPE_DPHY>;
+ #phy-cells = <0>;
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index b81e9fcc66cb..5da594fbb761 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13184,6 +13184,12 @@ F: Documentation/devicetree/bindings/media/mediatek-vpu.txt
F: drivers/media/platform/mediatek/vcodec/
F: drivers/media/platform/mediatek/vpu/
+MEDIATEK MIPI-CSI CDPHY DRIVER
+M: Julien Stephan <jstephan@baylibre.com>
+M: Andy Hsieh <andy.hsieh@mediatek.com>
+S: Supported
+F: Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
+
MEDIATEK MMC/SD/SDIO DRIVER
M: Chaotian Jing <chaotian.jing@mediatek.com>
S: Maintained
--
2.40.1
Il 24/05/23 10:30, Julien Stephan ha scritto: > From: Florian Sylvestre <fsylvestre@baylibre.com> > > This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in > some Mediatek soc, such as the mt8365 > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > new file mode 100644 > index 000000000000..a1bd96a98051 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek Sensor Interface MIPI CSI CD-PHY > + > +maintainers: > + - Julien Stephan <jstephan@baylibre.com> > + - Andy Hsieh <andy.hsieh@mediatek.com> > + > +description: > + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2 > + receivers. The number of PHYs depends on the SoC model. > + Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only > + capable. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8365-csi-rx > + > + reg: > + maxItems: 1 > + > + '#phy-cells': > + const: 0 > + > + mediatek,phy-type: Instead of declaring a phy-type here like this, can't we instead declare that in the phy cells, like we're doing with MTK TPHY and like other non-MediaTek PHYs are already doing? device { ... phys = <&csi0_rx PHY_TYPE_CDPHY>; ... } Regards, Angelo
On Wed, May 24, 2023 at 11:45:30AM +0200, AngeloGioacchino Del Regno wrote: > Il 24/05/23 10:30, Julien Stephan ha scritto: > > From: Florian Sylvestre <fsylvestre@baylibre.com> > > > > This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in > > some Mediatek soc, such as the mt8365 > > > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > --- > > .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 73 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > new file mode 100644 > > index 000000000000..a1bd96a98051 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2023 MediaTek, BayLibre > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mediatek Sensor Interface MIPI CSI CD-PHY > > + > > +maintainers: > > + - Julien Stephan <jstephan@baylibre.com> > > + - Andy Hsieh <andy.hsieh@mediatek.com> > > + > > +description: > > + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2 > > + receivers. The number of PHYs depends on the SoC model. > > + Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only > > + capable. > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8365-csi-rx > > + > > + reg: > > + maxItems: 1 > > + > > + '#phy-cells': > > + const: 0 > > + > > + mediatek,phy-type: > > Instead of declaring a phy-type here like this, can't we instead declare that in > the phy cells, like we're doing with MTK TPHY and like other non-MediaTek PHYs are > already doing? > > device { > ... > phys = <&csi0_rx PHY_TYPE_CDPHY>; > ... > } > > Regards, > Angelo > > Hi Angelo, This is a hardware property that is not dynamic, so IMHO it doesn't make sense to use phy argument for that. Some driver already use a 'phy-type' property (such as phy-cadence-torrent.yaml). I was thinking of using phy argument on future upgrade when driver will support D-PHY and C-PHY modes so the phy user will be able to choose the mode. Does it makes sense? Best Julien
On Wed, May 24, 2023 at 04:05:03PM +0200, Julien Stephan wrote: > On Wed, May 24, 2023 at 11:45:30AM +0200, AngeloGioacchino Del Regno wrote: > > Il 24/05/23 10:30, Julien Stephan ha scritto: > > > From: Florian Sylvestre <fsylvestre@baylibre.com> > > > > > > This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in > > > some Mediatek soc, such as the mt8365 > > > > > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > > --- > > > .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 67 +++++++++++++++++++ > > > MAINTAINERS | 6 ++ > > > 2 files changed, 73 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > > new file mode 100644 > > > index 000000000000..a1bd96a98051 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml > > > @@ -0,0 +1,67 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +# Copyright (c) 2023 MediaTek, BayLibre > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Mediatek Sensor Interface MIPI CSI CD-PHY > > > + > > > +maintainers: > > > + - Julien Stephan <jstephan@baylibre.com> > > > + - Andy Hsieh <andy.hsieh@mediatek.com> > > > + > > > +description: > > > + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2 > > > + receivers. The number of PHYs depends on the SoC model. > > > + Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only > > > + capable. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - mediatek,mt8365-csi-rx > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + '#phy-cells': > > > + const: 0 > > > + > > > + mediatek,phy-type: > > > > Instead of declaring a phy-type here like this, can't we instead declare that in > > the phy cells, like we're doing with MTK TPHY and like other non-MediaTek PHYs are > > already doing? > > > > device { > > ... > > phys = <&csi0_rx PHY_TYPE_CDPHY>; > > ... > > } > > > > Regards, > > Angelo > > > > > > Hi Angelo, > > This is a hardware property that is not dynamic, so IMHO it doesn't make sense > to use phy argument for that. Why? Interrupt numbers are fixed hardware properties which go in arg cells. > Some driver already use a 'phy-type' > property (such as phy-cadence-torrent.yaml). > > I was thinking of using phy argument on future upgrade when driver will > support D-PHY and C-PHY modes so the phy user will be able to choose the > mode. Once you design the binding, you don't get to change it. Rob
© 2016 - 2024 Red Hat, Inc.