RDMA/hns: Bugfix and improvements

[PATCH for-rc 0/3] RDMA/hns: Bugfix and improvements

Posted by Junxian Huang 2 years, 8 months ago

1. #1-#2: The first two patches improves diagnostic information to
   the driver.

2. #3: The third patch removes unnecessary QP type checks.


Chengchang Tang (2):
  RDMA/hns: Fix hns_roce_table_get return value
  RDMA/hns: Add clear_hem return value to log

Junxian Huang (1):
  RDMA/hns: Remove unnecessary QP type checks

 drivers/infiniband/hw/hns/hns_roce_hem.c   | 51 ++++++++++++++--------
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 22 ++--------
 2 files changed, 37 insertions(+), 36 deletions(-)

--
2.30.0

Re: [PATCH for-rc 0/3] RDMA/hns: Bugfix and improvements

Posted by Jason Gunthorpe 2 years, 8 months ago

On Tue, May 23, 2023 at 08:16:38PM +0800, Junxian Huang wrote:
> 1. #1-#2: The first two patches improves diagnostic information to
>    the driver.
> 
> 2. #3: The third patch removes unnecessary QP type checks.
> 
> 
> Chengchang Tang (2):
>   RDMA/hns: Fix hns_roce_table_get return value
>   RDMA/hns: Add clear_hem return value to log
> 
> Junxian Huang (1):
>   RDMA/hns: Remove unnecessary QP type checks

These are not -rc patches, they don't fix user facing things, so I put
them in for-next

Also there was a compile warning I fixed

../drivers/infiniband/hw/hns/hns_roce_hw_v2.c:767:20: warning: unused variable 'ibdev' [-Wunused-variable]
        struct ib_device *ibdev = &hr_dev->ib_dev;

Although it could probably use more fixing.

Jason

Re: [PATCH for-rc 0/3] RDMA/hns: Bugfix and improvements

Posted by Junxian Huang 2 years, 8 months ago


On 2023/6/2 7:00, Jason Gunthorpe wrote:
> On Tue, May 23, 2023 at 08:16:38PM +0800, Junxian Huang wrote:
>> 1. #1-#2: The first two patches improves diagnostic information to
>>    the driver.
>>
>> 2. #3: The third patch removes unnecessary QP type checks.
>>
>>
>> Chengchang Tang (2):
>>   RDMA/hns: Fix hns_roce_table_get return value
>>   RDMA/hns: Add clear_hem return value to log
>>
>> Junxian Huang (1):
>>   RDMA/hns: Remove unnecessary QP type checks
> 
> These are not -rc patches, they don't fix user facing things, so I put
> them in for-next
> 
> Also there was a compile warning I fixed
> 
> ../drivers/infiniband/hw/hns/hns_roce_hw_v2.c:767:20: warning: unused variable 'ibdev' [-Wunused-variable]
>         struct ib_device *ibdev = &hr_dev->ib_dev;
> 
> Although it could probably use more fixing.
> 
> Jason

Oops,that's our miss. Thanks!