sched: address missing-prototype warnings

[PATCH 0/5] sched: address missing-prototype warnings

Posted by Arnd Bergmann 2 years, 8 months ago

From: Arnd Bergmann <arnd@arndb.de>

I sent out a lot of -Wmissing-prototype warnings already, but noticed that
I missed some of the patches I did for the scheduler.

Addressing this is mainly useful in order to allow turning the
warning on by default in the future, but I also tried to
improe the code where possible.

Arnd Bergmann (5):
  sched: hide unused sched_update_scaling()
  sched: add schedule_user() declaration
  sched: fair: hide unused init_cfs_bandwidth() stub
  sched: make task_vruntime_update() prototype visible
  sched: fair: move unused stub functions to header

 kernel/sched/core.c  |  2 --
 kernel/sched/fair.c  | 19 +++----------------
 kernel/sched/sched.h | 13 +++++++++++++
 3 files changed, 16 insertions(+), 18 deletions(-)

-- 
2.39.2

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Segall <bsegall@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org

Re: [PATCH 0/5] sched: address missing-prototype warnings

Posted by Peter Zijlstra 2 years, 8 months ago

On Mon, May 22, 2023 at 09:50:16PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> I sent out a lot of -Wmissing-prototype warnings already, but noticed that
> I missed some of the patches I did for the scheduler.
> 
> Addressing this is mainly useful in order to allow turning the
> warning on by default in the future, but I also tried to
> improe the code where possible.
> 
> Arnd Bergmann (5):
>   sched: hide unused sched_update_scaling()
>   sched: add schedule_user() declaration
>   sched: fair: hide unused init_cfs_bandwidth() stub
>   sched: make task_vruntime_update() prototype visible
>   sched: fair: move unused stub functions to header
> 

Thanks!

Re: [PATCH 0/5] sched: address missing-prototype warnings

Posted by Vincent Guittot 2 years, 8 months ago

On Mon, 22 May 2023 at 21:50, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> I sent out a lot of -Wmissing-prototype warnings already, but noticed that
> I missed some of the patches I did for the scheduler.
>
> Addressing this is mainly useful in order to allow turning the
> warning on by default in the future, but I also tried to
> improe the code where possible.
>
> Arnd Bergmann (5):
>   sched: hide unused sched_update_scaling()
>   sched: add schedule_user() declaration
>   sched: fair: hide unused init_cfs_bandwidth() stub
>   sched: make task_vruntime_update() prototype visible
>   sched: fair: move unused stub functions to header

For the whole serie

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

>
>  kernel/sched/core.c  |  2 --
>  kernel/sched/fair.c  | 19 +++----------------
>  kernel/sched/sched.h | 13 +++++++++++++
>  3 files changed, 16 insertions(+), 18 deletions(-)
>
> --
> 2.39.2
>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ben Segall <bsegall@google.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: linux-kernel@vger.kernel.org
>